Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial end-to-end tests for streaming, reporting, generating #350

Merged
merged 5 commits into from
Dec 9, 2020
Merged

initial end-to-end tests for streaming, reporting, generating #350

merged 5 commits into from
Dec 9, 2020

Conversation

zenmoto
Copy link
Contributor

@zenmoto zenmoto commented Oct 6, 2020

Start on end-to-end tests for search commands

@zenmoto zenmoto force-pushed the end_to_end_searchcommand_tests branch from b4e6097 to 4f4e609 Compare October 7, 2020 18:34
amysutedja
amysutedja suggested changes Oct 19, 2020
View reviewed changes
splunklib/searchcommands/search_command.py Show resolved Hide resolved
tests/searchcommands/chunked_data_stream.py Outdated Show resolved Hide resolved
tests/searchcommands/chunked_data_stream.py Outdated Show resolved Hide resolved
tests/searchcommands/chunked_data_stream.py Show resolved Hide resolved
tests/searchcommands/chunked_data_stream.py Show resolved Hide resolved
tests/searchcommands/chunked_data_stream.py Outdated Show resolved Hide resolved
tests/searchcommands/chunked_data_stream.py Outdated Show resolved Hide resolved
tests/searchcommands/chunked_data_stream.py Outdated Show resolved Hide resolved
amysutedja
amysutedja approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@amysutedja amysutedja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending passing tests.

@zenmoto zenmoto merged commit 465522d into master Dec 9, 2020
@fantavlik fantavlik mentioned this pull request Jan 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amysutedja amysutedja amysutedja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zenmoto @amysutedja