Refine naming consistency for HttpRequestFactories and update RestOperations interface #33411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit renames three classes to improve naming consistency within the Spring Framework: - `ReactorNettyClientRequestFactory` -> `ReactorClientHttpRequestFactory` - `ReactorClientHttpConnector` -> `ReactorNettyClientHttpConnector` - `HttpComponentsClientHttpRequestFactory` -> `HttpComponentsClientRequestFactory` These changes align the class names with others in the project, reducing redundancy and improving clarity. This update affects 31 files. Issue: spring-projects#33382
- Updated references from `HttpComponentsClientHttpRequestFactory` to `HttpComponentsClientRequestFactory`. Issue: spring-projects#33382
|
@Torres-09 Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@Torres-09 Thank you for signing the Contributor License Agreement! |
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
in: web
|
I went with the simplest possible renaming: just |
jhoeller
added
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #33382 by refining the naming consistency within the Spring Framework.
Class Renaming
ReactorNettyClientRequestFactory->ReactorClientHttpRequestFactoryReactorClientHttpConnector->ReactorNettyClientHttpConnectorHttpComponentsClientHttpRequestFactory->HttpComponentsClientRequestFactoryRestOperationsInterface UpdateUpdated the
RestOperationsinterface to reflect the new class names, specifically changing references fromHttpComponentsClientHttpRequestFactorytoHttpComponentsClientRequestFactory.This update affects 32 files.
Testing
All relevant tests were executed locally using
./gradlew test, and all tests passed successfully. No regressions were introduced by the changes in this PR.Issue: #33382