Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support role_name and entity_alias in VaultTokenRequest #690

Closed
edmundham opened this issue Mar 28, 2022 · 1 comment
Closed

Support role_name and entity_alias in VaultTokenRequest #690

edmundham opened this issue Mar 28, 2022 · 1 comment
Labels
type: enhancement A general enhancement
Milestone
3.1.0-RC1

Comments

@edmundham
Copy link

Hi all,

From the vault documentation for creating token through API call, https://www.vaultproject.io/api-docs/auth/token#create-token they have role_name and entity_alias. However, current (2.3.2 version) VaultTokenRequest does not support these parameters. https://github.com/spring-projects/spring-vault/blob/2.3.2/spring-vault-core/src/main/java/org/springframework/vault/support/VaultTokenRequest.java

Can the team look into adding these?

Thanks in advance!
@mp911de
Copy link
Member

mp911de commented Mar 29, 2022

Feel free to submit a pull request.

@mp911de mp911de added type: enhancement A general enhancement status: ideal-for-contribution An issue that a contributor can help us with labels Mar 29, 2022
@mp911de mp911de mentioned this issue May 17, 2022
Closed
nbaars pushed a commit to nbaars/spring-vault that referenced this issue Jul 2, 2023
Support role_name while creating a token
9c3cf9a 
Closes: spring-projectsgh-690
nbaars pushed a commit to nbaars/spring-vault that referenced this issue Jul 2, 2023
Support entity_alias
8b99744 
Closes: spring-projectsgh-690
@nbaars nbaars mentioned this issue Jul 2, 2023
Closed
@mp911de mp911de removed the status: ideal-for-contribution An issue that a contributor can help us with label Oct 16, 2023
@mp911de mp911de added this to the 3.1.0-RC1 milestone Oct 16, 2023
mp911de added a commit that referenced this issue Oct 16, 2023
@mp911de
Polishing.
f42bd96 
Add since and author tags. Reorder fields.

Introduce empty VaultTokenRequest and refactor interface methods to default methods for delegation on the interface level.

See gh-690
Original pull request: gh-803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.1.0-RC1
Development

Successfully merging a pull request may close this issue.

Support role_name and entity_alias in VaultTokenRequest nbaars/spring-vault
2 participants
@mp911de @edmundham