Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package setup #146

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Update package setup #146

merged 4 commits into from
Apr 4, 2023

Conversation

freeatnet
Copy link
Contributor

@freeatnet freeatnet commented Feb 26, 2023

This PR updates the package setup with the goal of getting the package setup to work on Node 18 / npm v9.

Originally, I set out to investigate a CI failure on spruceid/siwe@main and found that the file: protocol dependencies specified in the root package.json were breaking with Node 18 and npm v9. While debugging the issue, I found that the current state of the package.json file could use some overall cleanup.

In sum total, this PR:

  • Converts the root package.json to use the workspaces directive and cleans up directives left over from before siwe became a monorepo.
  • Upgrades lerna to v6, with the most notable change being the deprecation of lerna bootstrap.
  • Adds Node 16 and 18 testing in ci.yaml, also upgrading to actions/checkout@v3.

Copy link
Member

@w4ll3 w4ll3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Will be performing some test to make sure nothing is broken.

@freeatnet
Copy link
Contributor Author

@w4ll3 rebased to resolve conflicts, let me know if anything else needs attention

@w4ll3
Copy link
Member

w4ll3 commented Apr 4, 2023

Hi there, sorry for the delay here. Could you push a commit to trigger the CI? Getting the green mark I'll merge this.

@freeatnet
Copy link
Contributor Author

@w4ll3 done

@w4ll3 w4ll3 merged commit 359968e into spruceid:main Apr 4, 2023
@w4ll3 w4ll3 mentioned this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants