-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package setup #146
Update package setup #146
Conversation
0c04ac9
to
445f371
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good. Will be performing some test to make sure nothing is broken.
445f371
to
89b295b
Compare
@w4ll3 rebased to resolve conflicts, let me know if anything else needs attention |
Hi there, sorry for the delay here. Could you push a commit to trigger the CI? Getting the green mark I'll merge this. |
89b295b
to
a3e7f38
Compare
a3e7f38
to
d74a8d8
Compare
@w4ll3 done |
This PR updates the package setup with the goal of getting the package setup to work on Node 18 / npm v9.
Originally, I set out to investigate a CI failure on
spruceid/siwe@main
and found that thefile:
protocol dependencies specified in the root package.json were breaking with Node 18 and npm v9. While debugging the issue, I found that the current state of thepackage.json
file could use some overall cleanup.In sum total, this PR:
package.json
to use theworkspaces
directive and cleans up directives left over from before siwe became a monorepo.lerna bootstrap
.actions/checkout@v3
.