Merge pull request #3715 from square/jw/kotlin/2022-03-29

Migrate Kotlin tests to separate project
square · Mar 30, 2022 · 4910b3c · 4910b3c
2 parents 00ff27e + fb62d2c
commit 4910b3c
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 7 deletions.
diff --git a/retrofit/build.gradle b/retrofit/build.gradle
@@ -17,8 +17,6 @@ dependencies {
   testImplementation libs.assertj
   testImplementation libs.guava
   testImplementation libs.mockwebserver
-  testImplementation libs.kotlinStdLib
-  testImplementation libs.kotlinCoroutines
 }
 
 jar {

diff --git a/retrofit/gradle.properties b/retrofit/gradle.properties
@@ -1,3 +1,5 @@
 POM_ARTIFACT_ID=retrofit
 POM_NAME=Retrofit
 POM_DESCRIPTION=A type-safe HTTP client for Android and Java.
+
+kotlin.stdlib.default.dependency=false
diff --git a/retrofit/kotlin-test/build.gradle b/retrofit/kotlin-test/build.gradle
@@ -0,0 +1,11 @@
+apply plugin: 'org.jetbrains.kotlin.jvm'
+
+dependencies {
+  testImplementation projects.retrofit
+  testImplementation projects.retrofit.testHelpers
+  testImplementation libs.junit
+  testImplementation libs.assertj
+  testImplementation libs.mockwebserver
+  testImplementation libs.kotlinStdLib
+  testImplementation libs.kotlinCoroutines
+}
diff --git a/...st/java/retrofit2/KotlinExtensionsTest.kt → ...st/java/retrofit2/KotlinExtensionsTest.kt b/...st/java/retrofit2/KotlinExtensionsTest.kt → ...st/java/retrofit2/KotlinExtensionsTest.kt
diff --git a/.../java/retrofit2/KotlinSuspendRawTest.java → .../java/retrofit2/KotlinSuspendRawTest.java b/.../java/retrofit2/KotlinSuspendRawTest.java → .../java/retrofit2/KotlinSuspendRawTest.java
diff --git a/.../test/java/retrofit2/KotlinSuspendTest.kt → .../test/java/retrofit2/KotlinSuspendTest.kt b/.../test/java/retrofit2/KotlinSuspendTest.kt → .../test/java/retrofit2/KotlinSuspendTest.kt
diff --git a/...c/test/java/retrofit2/KotlinUnitTest.java → ...c/test/java/retrofit2/KotlinUnitTest.java b/...c/test/java/retrofit2/KotlinUnitTest.java → ...c/test/java/retrofit2/KotlinUnitTest.java
@@ -21,7 +21,6 @@
 import kotlin.Unit;
 import okhttp3.mockwebserver.MockResponse;
 import okhttp3.mockwebserver.MockWebServer;
-import org.junit.Ignore;
 import org.junit.Rule;
 import org.junit.Test;
 import retrofit2.http.GET;
@@ -45,8 +44,4 @@ public void unitOnClasspath() throws IOException {
     assertThat(response.isSuccessful()).isTrue();
     assertThat(response.body()).isSameAs(Unit.INSTANCE);
   }
-
-  @Ignore("This is implicitly tested by integration tests of the adapters and converters")
-  @Test
-  public void unitMissingFromClasspath() {}
 }
diff --git a/settings.gradle b/settings.gradle
@@ -2,6 +2,7 @@ rootProject.name = 'retrofit-root'
 
 include ':retrofit'
 include ':retrofit:android-test'
+include ':retrofit:kotlin-test'
 include ':retrofit:robovm-test'
 include ':retrofit:test-helpers'