Migrate Kotlin tests to separate project #3715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
commented
Mar 30, 2022
| @@ -1,3 +1,5 @@ | |||
| POM_ARTIFACT_ID=retrofit | |||
| POM_NAME=Retrofit | |||
| POM_DESCRIPTION=A type-safe HTTP client for Android and Java. | |||
|
|
|||
| kotlin.stdlib.default.dependency=false | |||
There was a problem hiding this comment.
Our version of Kotlin is old enough that the stdlib isn't added by default. This is a hedge against future upgrades.
Goooler
approved these changes
Mar 30, 2022
This is easier than messing with classpaths.
JakeWharton
force-pushed
the
jw/kotlin/2022-03-29
branch
from
ab4d3a6
to
fb62d2c
Compare
mattprecious
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is easier than messing with classpaths.
Closes #3714