Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow buildFromSdist to ignore Rust drvs #294

Closed
wants to merge 1 commit into from

Conversation

srid
Copy link
Owner

@srid srid commented Apr 2, 2024

Resolves #292 as a hack, but what is the proper fix here for notorious (#293) buildFromSdist?

@srid srid force-pushed the buildFromSdist-rust branch from 9df5b22 to 6c73233 Compare April 3, 2024 00:46
@srid
Copy link
Owner Author

srid commented Apr 3, 2024

Closing in favour of #298

@srid srid closed this Apr 3, 2024
@roberth
Copy link
Collaborator

roberth commented Apr 21, 2024

ignore Rust drvs

I thought I could ignore this but it freaks me out, somehow.

Is it really necessary to do this?
If there's a good reason to do it this way, it might be acceptable to insert them into the overlay, as a hacky implementation, but in that case please make it a real feature with a separate option, so that it doesn't break by itself, and so that it can be deprecated when a better solution comes along.

@srid
Copy link
Owner Author

srid commented Apr 22, 2024

@roberth This PR got closed without being merged. Not sure what you are referring to. When you said "Is it really necessary to do this?" what are you referring to?

@srid
Copy link
Owner Author

srid commented Apr 22, 2024

@roberth I think you are referring to the regression which is now fixed in #306

@roberth
Copy link
Collaborator

roberth commented Apr 22, 2024

When you said "Is it really necessary to do this?" what are you referring to?

Having rust files in the overlay, supporting that.

I apologize if I'm replying to the wrong thread or necrobumping unnecessarily.

@srid
Copy link
Owner Author

srid commented Apr 24, 2024

When you said "Is it really necessary to do this?" what are you referring to?

Having rust files in the overlay, supporting that.

This should be already supported through the custom option; see

https://github.com/shivaraj-bh/haskell-rust-ffi-template/blob/0ea595271103161184332ad4c5322fbc1c93a711/haskell/default.nix#L7

https://nixos.asia/en/haskell-rust-ffi

Do you have a better interface in mind?

(There's a proposal that incidentally gets rid of this custom option; see #285)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buildFromSdist fails with Rust packages
2 participants