Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: use buildFromSdist for packages managed by haskell-flake only #306

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

srid
Copy link
Owner

@srid srid commented Apr 22, 2024

@srid srid force-pushed the defined-buildFromSdist branch 2 times, most recently from 197c073 to 9cb782f Compare April 22, 2024 07:51
@srid
Copy link
Owner Author

srid commented Apr 22, 2024

Reproduced,

❯ nix build github:shivaraj-bh/haskell-rust-ffi-template --override-input haskell-flake github:srid/haskell-flake
[..]
       error: attribute 'override' missing

       at /nix/store/fjvkr94j3lwca8y66zccn15rjwzqn0rd-source/pkgs/development/haskell-modules/lib/compose.nix:38:28:

           37|    */
           38|   overrideCabal = f: drv: (drv.override (args: args // {
             |                            ^
           39|     mkDerivation = drv: (args.mkDerivation drv).override f;

Tested the fix,

❯ nix build github:shivaraj-bh/haskell-rust-ffi-template --override-input haskell-flake github:srid/haskell-flake/9cb782f5338f983c6e77bbb8a573786a67492bcf
warning: not writing modified lock file of flake 'github:shivaraj-bh/haskell-rust-ffi-template':
• Updated input 'haskell-flake':
    'github:srid/haskell-flake/474fcb07635972baa325e47db84cc2195712da5a' (2024-03-28)
  → 'github:srid/haskell-flake/9cb782f5338f983c6e77bbb8a573786a67492bcf' (2024-04-22)

@srid srid force-pushed the defined-buildFromSdist branch from 9cb782f to e5cf5b2 Compare April 22, 2024 07:57
@srid srid merged commit a853283 into master Apr 22, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant