Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Missing dependency of package rsync #11

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

Tronde
Copy link
Contributor

@Tronde Tronde commented Sep 10, 2024

TL;DR

  • The package 'rsync' is used by the module ansible.posix.synchronize
  • Task 'extract_files | Extract files of mounted ISO to work directory' fails when package is missing
  • Added 'rsync' as a dependency in the same way as 'xorriso'

The epic explanaition

Hi Steffen,
I tried your awesome role on a fresh install of RHEL 9.4 and discovered the following task failure do to the missing package rsync:

TASK [sscheib.rhel_iso_kickstart : extract_files | Extract files of mounted ISO to work directory: /home/jkastnin/downloads/src] ***
task path: /home/jkastnin/proj_rhel_iso_kickstart/roles/sscheib.rhel_iso_kickstart/tasks/extract_files.yml:31
…
    "msg": "Failed to find required executable \"rsync\" in paths: /sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin"

According to ansible-doc ansible.posix.synchronize the module is only a wrapper for rsync that depends on the package to be present:

NOTES:
* rsync must be installed on both the local and remote host.

To fix this I added rsync as a dependency to the role.

In case you have any further questions, you know where to find me.

- The package 'rsync' is used by the module ansible.posix.synchronize
- Task 'extract_files | Extract files of mounted ISO to work directory' fails when package is missing
- Added 'rsync' as a dependency in the same way as 'xorriso'

Signed-off-by: Joerg Kastning <joerg@redhat.com>
@sscheib sscheib self-requested a review September 10, 2024 13:02
@sscheib
Copy link
Owner

sscheib commented Sep 10, 2024

Thanks for your contribution!

I assume you tested it on RHEL 9 prior to submitting the PR?

@Tronde
Copy link
Contributor Author

Tronde commented Sep 10, 2024

I assume you tested it on RHEL 9 prior to submitting the PR?

Yes, I ran it on a fresh RHEL 9.4 minimal installation with ansible-core, the collection ansible.posix and this role installed.

@sscheib sscheib merged commit 984a986 into sscheib:main Sep 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants