Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge upstream changes #1

Closed
wants to merge 315 commits into from

Conversation

SamuelCarliles3
Copy link
Collaborator

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

lesteve and others added 30 commits February 8, 2024 18:54
… doc build (scikit-learn#28372)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Tim Head <betatim@gmail.com>
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
scikit-learn#28390)

Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
…mpurity` (scikit-learn#28327)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
…cikit-learn#28167)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Co-authored-by: Adrin Jalali <adrin.jalali@gmail.com>
…eImputer` (scikit-learn#28365)

Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Co-authored-by: Tim Head <betatim@gmail.com>
Co-authored-by: Omar Salman <omar.salman@arbisoft.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
xuefeng-xu and others added 28 commits March 28, 2024 07:28
Co-authored-by: Jérémie du Boisberranger <jeremie@probabl.ai>
…tion (scikit-learn#28661)

Co-authored-by: Guillaume Lemaitre <guillaume@probabl.ai>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
#### Reference Issues/PRs
Fixes state of builder_ to not need to be maintained.

Prolly needs unit-tests to determine if this "functions as desired".
I.e.
- changing datatype of X over multiple partial fits should fail nicely, 
- changing datatype of y
- classification and regression

#### What does this implement/fix? Explain your changes.


#### Any other comments?


<!--
Please be aware that we are a loose team of volunteers so patience is
necessary; assistance handling other issues is very welcome. We value
all user contributions, no matter how minor they are. If we are slow to
review, either the pull request needs some benchmarking, tinkering,
convincing, etc. or more likely the reviewers are simply busy. In either
case, we ask for your understanding during the review process.
For more information, see our FAQ on this topic:

https://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.

Thanks for contributing!
-->

---------

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link

❌ Linting issues

There was an issue running the linter job. Please update with upstream/main (link) and push the changes. If you already have done that, please send an empty commit with git commit --allow-empty and push the changes to trigger the CI.

Generated for commit: 775f0b7. Link to the linter CI: here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.