Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix nullref on exiting dialer by long pressing of Back key on KYF33 #262

Merged
merged 5 commits into from
May 26, 2023
Merged

fix nullref on exiting dialer by long pressing of Back key on KYF33 #262

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
047364d
fix nullref on exiting com.android.dialer by long pressing of Back ke…
mcfrei May 20, 2023
229c671
fix misleading toString
mcfrei May 20, 2023
a811edf
add missing import
mcfrei May 20, 2023
2a89c3e
fix textField and inputType are assumed to be defined everywhere
mcfrei May 25, 2023
4f3c46e
fix yet another potential case of currentInputConnection = null
sspanak May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/io/github/sspanak/tt9/ime/TraditionalT9.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,9 @@ private void clearSuggestions() {
setSuggestions(null);

if (currentInputConnection != null) {
textField.setComposingText("");
if (textField != null) {
sspanak marked this conversation as resolved.
Show resolved Hide resolved
textField.setComposingText("");
}
currentInputConnection.finishComposingText();
}
}
Expand Down
8 changes: 8 additions & 0 deletions src/io/github/sspanak/tt9/ime/modes/ModeDialer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package io.github.sspanak.tt9.ime.modes;

import androidx.annotation.NonNull;

import io.github.sspanak.tt9.ime.helpers.Key;

// see: InputType.isDialer()
Expand All @@ -12,4 +14,10 @@ public class ModeDialer extends Mode123 {
public boolean onOtherKey(int key) {
return !Key.isDecimalSeparator(key) && super.onOtherKey(key);
}

@NonNull
@Override
public String toString() {
return "Dialer";
}
}