[Hub Generated] Review request for Microsoft.Maps to add version prev…

…iew/2020-02-01-preview (Azure#8359) * adding system data and description fixes * adding specific readonly and desc * fixing types systemData * remove sec def * pretty * trying to suppress
ssripadham · Feb 21, 2020 · b37a99a · b37a99a
1 parent 2d984b9
commit b37a99a
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 1 deletion.
diff --git a/specification/common-types/resource-management/v1/types.json b/specification/common-types/resource-management/v1/types.json
@@ -392,7 +392,7 @@
             "modelAsString": true
           }
         },
-        "lastModifiedByAt": {
+        "lastModifiedAt": {
           "type": "string",
           "format": "date-time",
           "description": "The type of identity that last modified the resource."

diff --git a/.../maps/resource-manager/Microsoft.Maps/preview/2020-02-01-preview/examples/GetAccount.json b/.../maps/resource-manager/Microsoft.Maps/preview/2020-02-01-preview/examples/GetAccount.json
@@ -12,6 +12,14 @@
         "name": "myMapsAccount",
         "type": "Microsoft.Maps/accounts",
         "location": "global",
+        "systemData": {
+          "createdBy": "string",
+          "createdByType": "Application",
+          "createdAt": "2020-02-01T01:01:01.1075056Z",
+          "lastModifiedBy": "string",
+          "lastModifiedByType": "Application",
+          "lastModifiedAt": "2020-02-01T01:01:01.1075056Z"
+        },
         "tags": {
           "test": "true"
         },

diff --git a/...tion/maps/resource-manager/Microsoft.Maps/preview/2020-02-01-preview/maps-management.json b/...tion/maps/resource-manager/Microsoft.Maps/preview/2020-02-01-preview/maps-management.json
@@ -724,6 +724,11 @@
           "description": "The SKU of this account.",
           "$ref": "#/definitions/Sku"
         },
+        "systemData": {
+          "readOnly": true,
+          "description": "The system meta data relating to this resource.",
+          "$ref": "../../../../../common-types/resource-management/v1/types.json#/definitions/systemData"
+        },
         "properties": {
           "readOnly": true,
           "description": "The map account properties.",

diff --git a/specification/maps/resource-manager/readme.md b/specification/maps/resource-manager/readme.md
@@ -179,6 +179,11 @@ directive:
       - Flattening does not work well with polymorphic models.
       - PrivateAtlas.properties is an arbitrary dictionary and cannot be flattened.  
       - MapsAccount.properties is an arbitrary dictionary and cannot be flattened.  
+  - suppress: R3006 # BodyTopLevelProperties
+    where:
+      - $.definitions.MapsAccount.properties
+    reason:
+      - Currently systemData is not allowed.
   - suppress: R3010  # TrackedResourceListByImmediateParent
     where:
       - $.definitions