Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composer: Allow lowest php version: 5.3 #65

Merged
merged 4 commits into from
Mar 13, 2021
Merged

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Mar 13, 2021

The code does not use (much) features from newer php versions.
But this tool is really useful for projects that support old versions, and want to use this tool.

Such use will be at their own risk, as this project doesn't CI test those versions.

example:

glensc added 4 commits March 13, 2021 11:32
Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
libxml_use_internal_errors() comes from that module

Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
Signed-off-by: Elan Ruusamäe <glen@pld-linux.org>
Copy link
Owner

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea. please go ahead 👍

@glensc
Copy link
Contributor Author

glensc commented Mar 13, 2021

@staabm thanks for your support!

however the CI failure, I think it never worked on forks?

@staabm
Copy link
Owner

staabm commented Mar 13, 2021

you could be right. since all tests are passing, this is good to go.

@staabm staabm merged commit ef8c1e1 into staabm:master Mar 13, 2021
@staabm
Copy link
Owner

staabm commented Mar 13, 2021

@glensc glensc deleted the patch-1 branch March 13, 2021 10:43
@glensc
Copy link
Contributor Author

glensc commented Mar 13, 2021

@staabm you may need to if: github.repository.name == "staabm/annotate-pull-request-from-checkstyle" condition there:

or review the whole workflow, as if it doesn't work for anybody but you, do you even want it there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants