Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use staabm/annotate-pull-request-from-checkstyle to report violatons in GitHub #66

Merged
merged 5 commits into from
Apr 9, 2021
Merged

Use staabm/annotate-pull-request-from-checkstyle to report violatons in GitHub #66

merged 5 commits into from
Apr 9, 2021

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Mar 13, 2021 •
edited
Loading

@glensc glensc force-pushed the lint-checkstyle-cs2pr branch 3 times, most recently from 71e6557 to 5bbc358 Compare March 14, 2021 10:08
@glensc glensc mentioned this pull request Mar 14, 2021
Merged
@glensc
Copy link
Contributor Author

glensc commented Apr 7, 2021

php-parallel-lint 1.3 was released:

so can update to use actual version, rather a branch

@glensc glensc force-pushed the lint-checkstyle-cs2pr branch 2 times, most recently from 7267587 to 5f2c5d4 Compare April 7, 2021 20:34
@glensc glensc marked this pull request as ready for review April 7, 2021 20:34
@glensc
Copy link
Contributor Author

glensc commented Apr 7, 2021

@falkenhawk ready now

@glensc
Copy link
Contributor Author

glensc commented Apr 9, 2021

The xml errors are weird, nothing has changed in zf1s yet rebuild fails:

perhaps setup-php broke php-xml?

@glensc glensc force-pushed the lint-checkstyle-cs2pr branch from 5f2c5d4 to 5397451 Compare April 9, 2021 12:19
falkenhawk
falkenhawk reviewed Apr 9, 2021
View reviewed changes
Copy link
Member

@falkenhawk falkenhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the tests failing are not caused by the changes in this PR (I re-ran the workflow on master https://github.com/zf1s/zf1/actions/runs/679790082), I will go ahead and merge this

@falkenhawk falkenhawk merged commit dd57455 into zf1s:master Apr 9, 2021
@glensc glensc deleted the lint-checkstyle-cs2pr branch April 9, 2021 13:57
@glensc glensc mentioned this pull request Aug 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falkenhawk falkenhawk falkenhawk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glensc @falkenhawk