Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all conformance classes to 1.0.0-rc.1 and fix several extension cc URIs with extra forward-slash #383

Merged

Conversation

philvarner
Copy link
Collaborator

Related Issue(s):

Description:

  • update all the conformance classes to be rc.1
  • fix the few extension conformance classes that had an extra / before the #
  • add the collections conformance class

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

@philvarner philvarner marked this pull request as ready for review March 25, 2022 16:50
Copy link
Collaborator

@geospatial-jeff geospatial-jeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We haven't implemented the changes to transactions extension (#384 and #385) but I don't think that is a big deal (https://github.com/radiantearth/stac-api-spec/blob/master/CHANGELOG.md#changed).

@philvarner
Copy link
Collaborator Author

LGTM! We haven't implemented the changes to transactions extension (#384 and #385) but I don't think that is a big deal (https://github.com/radiantearth/stac-api-spec/blob/master/CHANGELOG.md#changed).

Also PATCH support is missing:

To clarify,

To the overall point, there is an "attempt" to implement Txn Ext, so it's reasonable to advertise it, even if it isn't entirely conformant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants