Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transactions Extension: PUT endpoint is incorrect, should be /collections/{c_id}/items/{i_id} #385

Closed
philvarner opened this issue Mar 25, 2022 · 1 comment · Fixed by #425
Closed

Transactions Extension: PUT endpoint is incorrect, should be /collections/{c_id}/items/{i_id} #385

philvarner opened this issue Mar 25, 2022 · 1 comment · Fixed by #425
Labels
bug Something isn't working spec Compliance with STAC/OGC specifications

Comments

@philvarner
Copy link
Collaborator

Currently, the PUT endpoint is /collections/{c_id}/items. However, according to the Txn Ext spec, this is supposed to be /collections/{c_id}/items/{i_id}

This may be a bit challenging to implement, as there are no endpoints currently that take both a body and path or query parameters, so _create_endpoint may need a bit of refactoring to allow both.
@philvarner philvarner added bug Something isn't working spec Compliance with STAC/OGC specifications labels Mar 25, 2022
@philvarner philvarner mentioned this issue Mar 27, 2022
Merged
4 tasks
@duckontheweb
Copy link
Contributor

@philvarner I'm working on this as part of the PR to address #406 and #384. Should PUT /collections also be changed to PUT /collections/{c_id}?

duckontheweb added a commit that referenced this issue Jul 20, 2022
@duckontheweb
Fix Item PUT endpoint per #385
5d7f577
@duckontheweb duckontheweb mentioned this issue Jul 20, 2022
Merged
4 tasks
duckontheweb added a commit that referenced this issue Jul 21, 2022
@duckontheweb
Fix Item PUT endpoint per #385
bab44e7
duckontheweb added a commit that referenced this issue Aug 1, 2022
@duckontheweb
Fix Item PUT endpoint per #385
4aaff75
duckontheweb added a commit that referenced this issue Aug 2, 2022
@duckontheweb
Fix Item PUT endpoint per #385
b0f46db
geospatial-jeff pushed a commit that referenced this issue Aug 2, 2022
@duckontheweb
Use collection_id path parameter Items Transactions endpoints (#425)
d2fcf13 
* Add collection_id path parameter and check against Item collection property

* Fix unformatted f-strings

* Fix Item PUT endpoint per #385

* Update API tests to use new PUT paths

* Make equivalent changes to sqlalchemy backend

* Add CHANGELOG entry for #425

* Fix failing tests from previous merge

* Return 400 for Item id or collection conflicts
geospatial-jeff added a commit that referenced this issue Aug 2, 2022
@duckontheweb @geospatial-jeff
Return added Item/Collection in Transactions response (#424)
e6b353a 
* Add collection_id path parameter and check against Item collection property

* Fix unformatted f-strings

* Fix Item PUT endpoint per #385

* Update API tests to use new PUT paths

* Make equivalent changes to sqlalchemy backend

* Add CHANGELOG entry for #425

* Fix failing tests from previous merge

* Return 400 for Item id or collection conflicts

* Add failing tests

* Return added Item/Collection from Transactions endpoints

* Format changes

* Add CHANGES entry for #424

* Get Transactions Item response collection id from path parameter

* remove duplicate test cases

Co-authored-by: Jeff Albrecht <geospatialjeff@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working spec Compliance with STAC/OGC specifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use collection_id path parameter Items Transactions endpoints stac-utils/stac-fastapi
2 participants
@philvarner @duckontheweb