Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pass kwargs for io operations #372

Merged
merged 3 commits into from
Nov 14, 2022
Merged

feat: pass kwargs for io operations #372

merged 3 commits into from
Nov 14, 2022

Conversation

sharkinsspatial
Copy link
Contributor

@sharkinsspatial sharkinsspatial commented Nov 11, 2022 •
edited
Loading

Related Issue(s):

Description:
Changes FsspecStacIO base class to StacIO and adds concrete implementations of read_text and write_text which pass kwargs to fsspec.open.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

gadomski
gadomski requested changes Nov 14, 2022
View reviewed changes
Copy link
Member

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you add this to the CHANGELOG? Thanks!

@gadomski gadomski merged commit a38b0a6 into stac-utils:main Nov 14, 2022
@sharkinsspatial sharkinsspatial mentioned this pull request Dec 15, 2022
Closed
@gadomski gadomski added this to the v0.4.3 milestone Dec 15, 2022
@sharkinsspatial sharkinsspatial mentioned this pull request Jan 12, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadomski gadomski gadomski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.3
Development

Successfully merging this pull request may close these issues.

Support arbitrary kwargs for fsspec.open use.
2 participants
@sharkinsspatial @gadomski