Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing generic kwargs for IO operations. #21

Merged
merged 5 commits into from
Jan 13, 2023

Conversation

sharkinsspatial
Copy link
Contributor

@sharkinsspatial sharkinsspatial commented Jan 12, 2023

Before you submit a pull request, please fill in the following:

Related Issue(s):
This PR applies the functionality included in the core stactools module from stac-utils/stactools#372.

Description:
Fsspec backends may require generic kwargs provided by the client (requester_pays as an example).

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

@sharkinsspatial sharkinsspatial marked this pull request as ready for review January 13, 2023 02:02
@matthewhanson
Copy link
Member

@sharkinsspatial This is looking good to me, but Python 3.7 is failing because stactools dropped 3.7 support.
I think we can merge this as is, but should have a PR for dropping 3.7 and adding 3.10 and 3.11 to the tests and to setup.cfg

@sharkinsspatial
Copy link
Contributor Author

@matthewhanson Sounds good. If you merge this, I'll make a follow on PR to drop 3.7 support. We also have a pending PR to use the modernized stactools repo template that we'll try to submit today 👍

@matthewhanson matthewhanson merged commit 1891f46 into stactools-packages:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants