Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pyproject.toml #424

Merged
merged 2 commits into from
May 12, 2023
Merged

Use pyproject.toml #424

merged 2 commits into from
May 12, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented May 11, 2023 •
edited
Loading

Description:
Includes a pre-commit autoupdate. No functional code changes.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

@gadomski gadomski added this to the 0.5.0 milestone May 11, 2023
@gadomski gadomski requested a review from pjhartzell May 11, 2023 15:08
@gadomski gadomski self-assigned this May 11, 2023
@gadomski gadomski force-pushed the convert-to-pyproject-toml branch 4 times, most recently from f780ab6 to 914d528 Compare May 11, 2023 18:56
pjhartzell
pjhartzell reviewed May 12, 2023
View reviewed changes
Copy link
Collaborator

@pjhartzell pjhartzell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note that as discussed async, we will be adding the missing isort functionality to the ruff configuration, along with the --fix option.

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@gadomski gadomski force-pushed the convert-to-pyproject-toml branch from 914d528 to fd888de Compare May 12, 2023 13:26
gadomski added 2 commits May 12, 2023 07:29
@gadomski
feat: use pyproject.toml
3e1ee88 
Includes a pre-commit autoupdate. No functional code changes.
@gadomski
lint: isort via ruff
993decc
@gadomski gadomski force-pushed the convert-to-pyproject-toml branch from fd888de to 993decc Compare May 12, 2023 13:29
@gadomski gadomski requested a review from pjhartzell May 12, 2023 13:30
@gadomski gadomski mentioned this pull request May 12, 2023
Merged
5 tasks
@gadomski gadomski merged commit ba81463 into main May 12, 2023
@gadomski gadomski deleted the convert-to-pyproject-toml branch May 12, 2023 14:09
@gadomski gadomski modified the milestones: 0.5.0, 0.4.8 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjhartzell pjhartzell pjhartzell approved these changes

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
0.4.8
Development

Successfully merging this pull request may close these issues.
2 participants
@gadomski @pjhartzell