Use the antimeridian package #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
force-pushed
the
issues/421-antimeridian
branch
from
a9b959f to
fbdee70
Compare
gadomski
force-pushed
the
issues/421-antimeridian
branch
from
fbdee70 to
1dc285b
Compare
gadomski
commented
May 12, 2023
gadomski
commented
May 12, 2023
ircwaves
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
We used to implement antimeridian fixes in this package, but we recently created https://github.com/gadomski/antimeridian. This package does more, is better tested, and has fewer dependencies (only shapely). This PR updates stactools to use that package.
The
fix_itemfunction is the most valuable -- the antimeridian package doesn't know anything about STAC, so stactools adds value by updating the item's geometry and bounding box after the fix. The rest of the functions are deprecated, as folks should use antimeridian instead.All "normalization" functions are deprecated, as "normalization" (using longitudes > 180 or <-180 to create a single polygon that crosses the antimeridian) doesn't conform to the GeoJSON spec.
PR checklist:
scripts/format).scripts/lint).scripts/test).