Feat/chain-id #3111

jcnelson · 2022-04-22T02:28:29Z

This PR address #2982 by adding chain-id as a global variable in Clarity2, which resolves to StacksChainState::chain_id.

… value in GlobalContext (which in turn gets it from the ClarityInstance, from StacksChainState)

…structs for block and transaction connections

…calls

… binary

codecov · 2022-04-22T02:56:03Z

Codecov Report

Merging #3111 (2747901) into next (e9f7949) will decrease coverage by 0.21%.
The diff coverage is 83.38%.

@@            Coverage Diff             @@
##             next    #3111      +/-   ##
==========================================
- Coverage   83.97%   83.75%   -0.22%     
==========================================
  Files         265      265              
  Lines      207719   207954     +235     
==========================================
- Hits       174426   174166     -260     
- Misses      33293    33788     +495

Impacted Files	Coverage Δ
clarity/src/vm/analysis/type_checker/mod.rs	`93.69% <0.00%> (-0.15%)`	⬇️
src/core/mod.rs	`76.84% <ø> (ø)`
src/util_lib/db.rs	`82.28% <0.00%> (-0.57%)`	⬇️
stacks-common/src/libcommon.rs	`100.00% <ø> (ø)`
src/chainstate/burn/db/sortdb.rs	`95.22% <40.00%> (-0.25%)`	⬇️
testnet/stacks-node/src/run_loop/neon.rs	`80.00% <53.33%> (-0.65%)`	⬇️
src/chainstate/coordinator/mod.rs	`90.67% <55.55%> (-1.73%)`	⬇️
src/clarity_cli.rs	`76.80% <66.66%> (-0.08%)`	⬇️
src/clarity_vm/tests/large_contract.rs	`81.19% <66.66%> (ø)`
clarity/src/vm/analysis/arithmetic_checker/mod.rs	`92.64% <100.00%> (ø)`
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2af13c...2747901. Read the comment docs.

… do it on node boot-up. Also, downgrade the tx type for migraiton to DBTx so we don't accidentally depend on the first block header information (which we might not have)

…s public key, so also make sure that the last contact time is positive when considering timeouts

… migrations

…ell as the `allowed` column

…to the latest schema before header sync

gregorycoppola · 2022-04-22T16:35:56Z

clarity/src/vm/tests/simple_apply_eval.rs

+                execute_with_parameters(
+                    program,
+                    ClarityVersion::Clarity2,
+                    StacksEpochId::Epoch20,


why not Epoch21? same as below.

Ah, that's an oversight on my end. Will fix.

Bootup fixes for 2.05.0.2.0-rc1

Feat: rename blockstack-core to stacks-inspect

clarity/src/vm/contexts.rs

src/clarity_vm/tests/analysis_costs.rs

obycode

Thanks for that change with test_only_mainnet_to_chain_id.

clarity/src/vm/costs/mod.rs

clarity/src/vm/contexts.rs

clarity/src/vm/mod.rs

src/clarity_vm/tests/analysis_costs.rs

src/clarity_vm/tests/events.rs

…universally in test paths

obycode

LGTM!

blockstack-devops · 2024-11-18T00:22:34Z

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

jcnelson added 3 commits April 21, 2022 22:26

feat: add chain-id global variable, which evaluates to the chain_id…

f8c824a

… value in GlobalContext (which in turn gets it from the ClarityInstance, from StacksChainState)

chore: add unit tests for chain-id variable

450039b

chore: plumb through chain_id into ClarityInstance and its dependant …

16da7ba

…structs for block and transaction connections

jcnelson requested review from kantai and gregorycoppola April 22, 2022 02:28

jcnelson added 3 commits April 21, 2022 22:28

chore: sync APIs to pass along chain_id

a94dfe5

chore: sync APIs to pass along chain_id, and add docs for chain-id

4f30cf4

chore: pass through StacksChainState's chain_id into Clarity-related …

1a04a10

…calls

jcnelson added the stacks-2.1 label Apr 22, 2022

jcnelson added 4 commits April 21, 2022 22:29

chore: sync APIs in tests to require chain_id

ea9552c

refactor: put chain IDs in stacks_common::consts

3a41660

chore: pass through chain ID into RPC calls that interact with Clarity

4f543c0

chore: deduce and pass reasonable chain ID values for the clarity-cli…

309b4e7

… binary

jcnelson added 6 commits April 22, 2022 11:35

fix: add separate DB migration function so the chains coordinator can…

cb6861d

… do it on node boot-up. Also, downgrade the tx type for migraiton to DBTx so we don't accidentally depend on the first block header information (which we might not have)

feat: add function to check and migrate chainstate DBs if they exist

485e450

fix: an always-allowed peer is already authenticated since we have it…

dfc4c49

…s public key, so also make sure that the last contact time is positive when considering timeouts

chore: add OldSchema(..) and TooOldForEpoch error variants for schema…

32741c8

… migrations

fix: update the public key of an always-allowed peer on boot-up, as w…

889bc9b

…ell as the `allowed` column

fix: if the chainstate DBs exist already, then they must be migrated …

8f472cf

…to the latest schema before header sync

gregorycoppola approved these changes Apr 22, 2022

View reviewed changes

jcnelson and others added 3 commits April 23, 2022 19:55

fix: use Epoch21 with Clarity2

abaf6cf

Merge pull request #3112 from stacks-network/fix/first-block-header

118187d

Bootup fixes for 2.05.0.2.0-rc1

feat: rename blockstack-core to stacks-inspect

906130a

jcnelson requested review from obycode and lgalabru April 25, 2022 17:14

kantai added 2 commits April 25, 2022 12:56

fix: update build scripts, etc. with stacks-inspect

1d46436

Merge pull request #3113 from stacks-network/feat/rename-core

16fe381

Feat: rename blockstack-core to stacks-inspect

jcnelson changed the base branch from chore/merge-develop-to-next to next April 26, 2022 15:44

obycode reviewed Apr 27, 2022

View reviewed changes

clarity/src/vm/contexts.rs Show resolved Hide resolved

src/clarity_vm/tests/analysis_costs.rs Outdated Show resolved Hide resolved

jcnelson added 4 commits April 27, 2022 11:52

chore: use a *test-only* helper method to choose the right chain ID

9a07bbc

Merge branch 'next' into feat/chain-id

6f93b7d

fix: compile-time errors in test_only_mainnet_to_chain_id

46f38d6

Merge branch 'develop' into feat/chain-id

4c8204d

jcnelson requested a review from obycode April 27, 2022 16:57

jcnelson added 2 commits April 27, 2022 13:04

fix: only import test code in test gates

35f8954

fix: gate import of test code for tests only

be117c8

obycode reviewed Apr 27, 2022

View reviewed changes

jcnelson added 2 commits April 27, 2022 13:58

fix: clean up unused imports and use test_only_mainnet_to_chain_id() …

7307507

…universally in test paths

Merge branch 'next' into feat/chain-id

2747901

obycode approved these changes Apr 27, 2022

View reviewed changes

jcnelson merged commit 9407d62 into next Apr 27, 2022

blockstack-devops added the locked label Nov 18, 2024

stacks-network locked as resolved and limited conversation to collaborators Nov 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/chain-id #3111

Feat/chain-id #3111

jcnelson commented Apr 22, 2022

codecov bot commented Apr 22, 2022 •

edited

Loading

gregorycoppola Apr 22, 2022

jcnelson Apr 23, 2022

obycode left a comment

obycode left a comment

blockstack-devops commented Nov 18, 2024

Feat/chain-id #3111

Feat/chain-id #3111

Conversation

jcnelson commented Apr 22, 2022

codecov bot commented Apr 22, 2022 • edited Loading

Codecov Report

gregorycoppola Apr 22, 2022

Choose a reason for hiding this comment

jcnelson Apr 23, 2022

Choose a reason for hiding this comment

obycode left a comment

Choose a reason for hiding this comment

obycode left a comment

Choose a reason for hiding this comment

blockstack-devops commented Nov 18, 2024

codecov bot commented Apr 22, 2022 •

edited

Loading