-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoX-4 Clarunit Setup & Initial Tests #4231
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4231 +/- ##
==========================================
- Coverage 83.46% 83.19% -0.27%
==========================================
Files 448 453 +5
Lines 323930 325191 +1261
Branches 0 316 +316
==========================================
+ Hits 270352 270530 +178
- Misses 53578 54653 +1075
- Partials 0 8 +8
... and 27 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments
@setzeus package The package can be replaced and pinned. I assume we can move the PR out of draft after that? |
Yeap @MarvinJanssen will do! Though atm this is on pause until at least EOM / Argon completion.* |
f14ef3d
to
ecbf216
Compare
ecbf216
to
5edc6f6
Compare
df6ba3d
to
8933c5b
Compare
Note: per the ClarityWG discussion on 2/27, this PR does NOT include a generated coverage file. There were a few issues in how & where it's generated so we're creating an issue as a placeholder to ensure we deal with it next. |
I understood we want to merge this sooner rather than later and work on code coverage in the next PR. |
Codecov now picks up the Clarinet coverage report. Up until now it was silently failing because the path was incorrect. I added See #4434 for more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shipit
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This PR introduces the new
@stacks/clarunit
to allow for writing boot contract unit tests in Clarity. Clarunit is uses Clarinet SDK so all the goodness that comes with Clarinet is preserved.Only some basic tests are introduced in this PR. Increasing code coverage will be done in follow-up PRs.
Applicable issues
Issue wasn't created but this is a continuation of the work done in #4100.