Updated Vote Print Statement #4324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #4324 +/- ##
===========================================
- Coverage 82.01% 59.27% -22.74%
===========================================
Files 435 435
Lines 309278 309278
===========================================
- Hits 253652 183334 -70318
- Misses 55626 125944 +70318 ☔ View full report in Codecov by Sentry. |
jcnelson
approved these changes
Feb 1, 2024
kantai
approved these changes
Feb 1, 2024
setzeus
force-pushed
the
update-pox-4-vote-print
branch
from
4fe7113 to
339829f
Compare
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed during Un/block meeting, the simplest/fastest solution for #4231 is simply to update the print statement found in 'vote-for-aggregate-public-key.'
The node will then take this information & then check whether the consensus threshold was met / a new aggregate public key has been submitted.
Since this is a simple print statement update there are no additional test to write.