feat(#1316): Implemented search bar on org home page #17
Conversation
|
@ecurrencyhodler Could you please have a look? |
Added Github Actions
Signed-off-by: Vividh Pandey <vividh.pandey.13@gmail.com>
|
Video looks good. Sorry one more thing. We have reverted our backend api calls from api.people-test->people.test. So we no longer will require the "api" in front of the call. Can you push another commit? I think that'll trigger our github actions workflows for testing. Also in the future, you can run the tests locally as well using: |
Sure. Let me push another commit. |
Include labels in issue templates
|
Okay let's get a code review. Gj! |
Include labels in issue templates
Fix: #1437
The main purpose of the hook is to call appropriate methods of models Added for responsibility allocation and simplify testing of the functionality Relates: #1408
…-buttons Implement Dynamic Display of Organization Website and GitHub Buttons in Org Home Page
Update the github readme for the frontend repo of sphinx-tribes
Fix(Bounty-Page): Enhanced Navigation for Direct Access to Bounty Pages
…person-page Fix/1408 people search on person page
implement the status filter on the org homepage
|
@AbdulWahab3181 Please fix merge conflicts. |
AbdulWahab3181
force-pushed
the
org-search-bar
branch
from
94d7992
to
be2ef45
Compare
…g-after-page-refresh fix(ui): keep `searchText` in local storage
@elraphty Resolved |
| onChange={(e: any) => { | ||
| ui.setSearchText(e); | ||
| }} | ||
| onKeyUp={(e: any) => { |
There was a problem hiding this comment.
Try to avoid Inline functions, create the search function outside the component, and call it in the onKeyUp event.
|
@elraphty this is from @AbdulWahab3181. org home page api call isn't working. "When I make a request to the https://people-test.sphinx.chat/organizations/bounties/cmkln4tm098m49vhlt80?limit=10&sortBy=created&search=test&page=1&resetPage=true endpoint with the search parameter set to 'test,' I receive a null response. However, it works correctly with the 'gobounties/all' endpoint, as demonstrated here: https://people-test.sphinx.chat/gobounties/all?limit=10&sortBy=created&search=test&page=1&resetPage=true&Open=true&Assigned=false&Paid=false&org_uuid=cmkln4tm098m49vhlt80." |
I have created this pull request PR stakwork/sphinx-tribes#1460 to address the issue. Kindly review it and consider merging. Additionally, I've submitted another pull request PR #33 in the frontend repository to handle this issue. This new pull request utilizes the "organizations/bounties" endpoint for search, aligning with the approach used by other components such as status. Considering the changes introduced in these new pull requests, I think we should have to close this PR as it is no longer necessary. The proposed modifications in the latest pull requests has adequately address the issue. |
|
Hey Abdul. Raph is going to take a look at both of those PR's and leave some comments for you. |
|
Hi Ecurrencyhodler, okay, I am waiting. |
|
@AbdulWahab3181 The Org bounty search is not working, I tested with the test server backend server and my local master branch Test Server Local Server Fix it |
@elraphty Changes have been incorporated into #33 pull request. Please try it out and ensure that your local server or test server also reflect these changes from stakwork/sphinx-tribes#1460 and stakwork/sphinx-tribes#1467. I intend to close this pull request as it is no longer in use. |
Describe your changes
video1235284858.mp4
Unit Test
Issue ticket number and link
Closes #190
Type of change
Please delete options that are not relevant.
Checklist before requesting a review