Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#1316): Implemented search bar on org home page #33

Closed

Conversation

AbdulWahab3181
Copy link
Contributor

@AbdulWahab3181 AbdulWahab3181 commented Jan 26, 2024

Depends On

stakwork/sphinx-tribes#1460

Describe your changes

video1040441988.online-video-cutter.com.mp4

Issue ticket number and link

Closes #190

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have tested on Chrome and Firefox
  • I have tested on a mobile device
  • I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

@kevkevinpal
Copy link
Collaborator

@AbdulWahab3181 if you can fix the merge conflicts that would be great!

@AbdulWahab3181
Copy link
Contributor Author

AbdulWahab3181 commented Feb 1, 2024

@AbdulWahab3181 if you can fix the merge conflicts that would be great!

@kevkevinpal Fixed

@Vayras
Copy link
Contributor

Vayras commented Feb 2, 2024

@AbdulWahab3181 Rebasing to master will fix the test failing

@kevkevinpal
Copy link
Collaborator

@AbdulWahab3181 you seem to have more merge conflicts please resolve them and rebase to master

@kevkevinpal
Copy link
Collaborator

also @AbdulWahab3181 it seems like you have 18 separate commits in this change if you maintain a branch with less commits it will be easier to review and will easier for you to rebase to master

@Vayras
Copy link
Contributor

Vayras commented Feb 3, 2024

@AbdulWahab3181 Rebase to master to fix the test failing

@Vayras
Copy link
Contributor

Vayras commented Feb 6, 2024

https://www.loom.com/share/c84db46c0d3a4849aa61d162dcea8aa9
upon testing this locally certain search terms do not work

@AbdulWahab3181
Copy link
Contributor Author

@Vayras It's working as expected, as you can see in the attached video. Please ensure that the code from stakwork/sphinx-tribes#1476 and stakwork/sphinx-tribes#1460 is deployed on the specified environment that you are using.
https://www.loom.com/share/ba99f9a9168a4c5da6b1b24e990654cd

@Vayras
Copy link
Contributor

Vayras commented Feb 7, 2024

@AbdulWahab3181 let me test this again, I would still like to say that search term including values in bracket might not work for example "searching for plebnet" yielded me nothing.

@Vayras
Copy link
Contributor

Vayras commented Feb 7, 2024

@AbdulWahab3181 so now the search is working as intented , but If I fail the search and replace the search term and do not press return on my keyboard I see infinite loading , can we make it so when the search term is removed we see all the bounties again?
see this attached video for reference
https://www.loom.com/share/04b074e745264b73be064705ab3e0988

@Vayras
Copy link
Contributor

Vayras commented Feb 7, 2024

@AbdulWahab3181 also you might need to squash your commits

@AbdulWahab3181
Copy link
Contributor Author

@Vayras Resolved https://www.loom.com/share/4013334f02b94e23b1c07f38a010ecf1. Could you please try now?

@Vayras
Copy link
Contributor

Vayras commented Feb 7, 2024

@AbdulWahab3181 Great Job, this works correctly now

@Vayras
Copy link
Contributor

Vayras commented Feb 7, 2024

once the workflows are approved and all the checks have passed, and you can find a way to squash your commits @kevkevinpal can get this merged.

@AbdulWahab3181 AbdulWahab3181 force-pushed the org-search-bar-v2 branch 2 times, most recently from ec03a48 to dc00bfa Compare February 7, 2024 15:42
@AbdulWahab3181
Copy link
Contributor Author

once the workflows are approved and all the checks have passed, and you can find a way to squash your commits @kevkevinpal can get this merged.

@kevkevinpal @Vayras I have created this PR #194 to prevent squashing commits, as the current PR is too old and has a lot of changes. It's really difficult to resolve multiple conflicts on multiple files without knowledge of others' work. Please review and merge this PR #194 and close the current one

@kevkevinpal
Copy link
Collaborator

closing this PR since there is a newer one to review

@kevkevinpal kevkevinpal closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement search bar on org home page
4 participants