Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code from mobile view of setting bounty status as open if github issue is open #1143

Closed
2 tasks
ecurrencyhodler opened this issue Dec 19, 2023 · 4 comments
Closed
2 tasks

Remove code from mobile view of setting bounty status as open if github issue is open #1143

ecurrencyhodler opened this issue Dec 19, 2023 · 4 comments
Assignees
@gouravmpk
Labels
bounties bug Something isn't working Posted
Milestone
Dec '23

Comments

@ecurrencyhodler
Copy link
Contributor

Describe the bug
There is currently code in mobile view where the status of the bounty is set to "open" if the github issue is still open. This was previously used to to track status of issues, not status of bounties.

This means that bounties marked as paid are viewed as "open" when you click into a bounty in mobile view.
Screenshot 2023-12-18 at 10 25 06 AM
Screenshot 2023-12-18 at 10 25 16 AM

Let's remove this code. Instead the status of the bounty should be set by status of the bounty.

Expected behavior
Status of the bounty should be set by status of the bounty.

Smartphone (please complete the following information):

  • Device: iPhone or Android
  • Browser: Chrome

Acceptance Criteria

  • I have tested on mobile Chrome
  • I have posted a video clicking on a paid bounty on the home page and it showing the status as "paid" inside viewing the bounty page as well
@ecurrencyhodler ecurrencyhodler added bug Something isn't working bounties labels Dec 19, 2023
@ecurrencyhodler ecurrencyhodler added this to the Cycle 1 milestone Dec 19, 2023
@gouravmpk
Copy link
Contributor

Assign

@gouravmpk
Copy link
Contributor

@ecurrencyhodler Just for clarification if bounty is paid it shouldn't show open in mobile view, is that correct !!

@ecurrencyhodler
Copy link
Contributor Author

No.

There is code that sets the bounty to open if the GitHub issue is open even if the bounty has been completed.

Remove this code.

If the bounty is paid, the status should be paid regardless of what the GitHub issue was in mobile.

@gouravmpk gouravmpk mentioned this issue Dec 21, 2023
Merged
kevkevinpal pushed a commit that referenced this issue Dec 26, 2023
@gouravmpk
Remove code from mobile view of setting bounty status as open if gith…
3f7c62d 
…ub issue is open (#1164)

* #1143

* removing the code in StatusPill which sets the bounty to open or closed from github issues.

* prettier

* changed GithubStatusPill to StatusPill

* removed status

* REMOVED commented part
kevkevinpal pushed a commit that referenced this issue Dec 26, 2023
@gouravmpk
Add bounty status (#1187)
8ffa97d 
* #1143

* removing the code in StatusPill which sets the bounty to open or closed from github issues.

* prettier

* changed GithubStatusPill to StatusPill

* removed status

* REMOVED commented part

* adding bounty status Try1

* colours changes

* Some missing changes

* prettier

* removed wrapper

* wrapper added just removed condition

* Also Added banner in mobile bounty view after opening the bounty #1126

* prettier

* removed unused text
@ecurrencyhodler
Copy link
Contributor Author

Closed by #1164

elraphty pushed a commit that referenced this issue Jan 26, 2024
@gouravmpk
Remove code from mobile view of setting bounty status as open if gith…
f78065b 
…ub issue is open (#1164)

* #1143

* removing the code in StatusPill which sets the bounty to open or closed from github issues.

* prettier

* changed GithubStatusPill to StatusPill

* removed status

* REMOVED commented part
elraphty pushed a commit that referenced this issue Jan 26, 2024
@gouravmpk
Add bounty status (#1187)
456211c 
* #1143

* removing the code in StatusPill which sets the bounty to open or closed from github issues.

* prettier

* changed GithubStatusPill to StatusPill

* removed status

* REMOVED commented part

* adding bounty status Try1

* colours changes

* Some missing changes

* prettier

* removed wrapper

* wrapper added just removed condition

* Also Added banner in mobile bounty view after opening the bounty #1126

* prettier

* removed unused text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gouravmpk gouravmpk

Labels
bounties bug Something isn't working Posted
Projects
Bounties Platform
Status: ✅ Done
Milestone
Dec '23
Development

No branches or pull requests
2 participants
@gouravmpk @ecurrencyhodler