Remove code from mobile view of setting bounty status as open if github issue is open #1164

gouravmpk · 2023-12-21T20:13:02Z

Describe your changes

Edited StatusPill

Issue ticket number and link

#1143

[ ✅ ] Bug fix (non-breaking change which fixes an issue)

Checklist before requesting a review

[✅ ] I have performed a self-review of my code
[✅ ] I have tested on Chrome and Firefox
[ ✅ ] I have tested on a mobile device
[✅ ] I have provided a screenshot or recording of changes in my PR if there were updates to the frontend

Video

open.bounty.remove.from.mobal.view.mp4

Note:

I'm not entirely certain if this aligns with the request, but in this pull request, I removed the code in StatusPill that typically sets the bounty status based on GitHub issues. This code previously determined whether the bounty status was 'Open' or 'Closed' based on the GitHub issues status. However, I observed that there is no other property or variable where the status of the bounty is being set. Could you please confirm if this is the intended change?
@kevkevinpal @ecurrencyhodler

…sed from github issues.

frontend/app/src/people/widgetViews/parts/StatusPill.tsx

kevkevinpal · 2023-12-22T04:57:19Z

looks good just added one comment cause we should rename this file if we arent using the github user assigned stuff anymore

gouravmpk · 2023-12-22T20:08:34Z

@kevkevinpal is this fine

kevkevinpal · 2023-12-22T21:10:13Z

frontend/app/src/people/widgetViews/parts/StatusPill.tsx

-      <Pill isOpen={isOpen}>
-        <div>{isOpen ? 'Open' : 'Closed'}</div>
-      </Pill>
+      <Pill isOpen={isOpen}>{/* <div>{isOpen ? 'Open' : 'Closed'}</div> */}</Pill>


we can delete this pill since there is no children to the component

kevkevinpal · 2023-12-22T21:10:34Z

frontend/app/src/people/widgetViews/parts/StatusPill.tsx

@@ -55,7 +55,7 @@ const W = styled.div`
  display: flex;
  align-items: center;
 `;
-export default function GithubStatusPill(props: GithubStatusPillProps) {
+export default function StatusPill(props: StatusPillProps) {
  const { status, assignee, style } = props;


We can delete the status prop since that is no longer being used

ecurrencyhodler · 2023-12-22T22:59:40Z

@gouravmpk Based on your video, it looks like the bounty is missing the status of: open/assigned/closed. Is that right?

This is what your video shows:

This is what it should show and is currently live in production:

We shouldn't be removing the status of the bounty in mobile you. All we're doing is removing the code that auto-sets the status of the bounty as "open" if the github issue is still open.

gouravmpk · 2023-12-23T07:06:56Z

Hey @ecurrencyhodler The status of the bounty is coming from GitHub issue only there is no other code or rather a property which sets bounty status except GitHub status ,this is my observation is that correct @kevkevinpal

ecurrencyhodler · 2023-12-23T13:54:29Z

Interesting. Okay if that's the case we can merge this and handle the actual status of the bounty in ~~#1161~~. Jk I'll need to create a separate issue to handle this.

gouravmpk · 2023-12-23T13:57:59Z

Interesting. Okay if that's the case we can merge this and handle the actual status of the bounty in #1161

Yep it would make sense.

kevkevinpal · 2023-12-24T02:24:53Z

ya @ecurrencyhodler the status on here is for the github issue and the status of the bounty itself should be separate issues, I the scope of this PR is good as we're just removing the github status.

Will review in a bit

kevkevinpal · 2023-12-24T02:25:53Z

frontend/app/src/people/widgetViews/parts/StatusPill.tsx

+// interface PillProps {
+//   readonly isOpen: boolean;
+// }
+// const Pill = styled.div<PillProps>`
+//   display: flex;
+//   justify-content: center;
+//   align-items: center;
+//   font-size: 12px;
+//   font-weight: 300;
+//   background: ${(p: any) => (p.isOpen ? '#49C998' : '#8256D0')};
+//   border-radius: 30px;
+//   border: 1px solid transparent;
+//   text-transform: capitalize;
+//   padding: 12px 5px;
+//   // padding:8px;
+//   font-size: 12px;
+//   font-weight: 500;
+//   line-height: 20px;
+//   white-space: nowrap;
+//   border-radius: 2em;
+//   height: 26px;
+//   color: #fff;
+//   margin-right: 10px;
+//   width: 58px;
+//   height: 22px;
+//   left: 19px;
+//   top: 171px;

-  /* Primary Green */
+//   /* Primary Green */

-  border-radius: 2px;
-`;
+//   border-radius: 2px;
+// `;


you can delete this if it is not being used

kevkevinpal · 2023-12-24T02:26:47Z

I think it looks good if you can remove the commented code

gouravmpk · 2023-12-24T06:42:01Z

I think it looks good if you can remove the commented code

Okay I am on it .

gouravmpk · 2023-12-24T19:02:00Z

@kevkevinpal I think this is good to go please check

kevkevinpal · 2023-12-26T16:09:34Z

looks good to me nice work!

…ub issue is open (#1164) * #1143 * removing the code in StatusPill which sets the bounty to open or closed from github issues. * prettier * changed GithubStatusPill to StatusPill * removed status * REMOVED commented part

gouravmpk added 3 commits December 22, 2023 00:20

#1143

7d968b8

removing the code in StatusPill which sets the bounty to open or clo…

dd695e9

…sed from github issues.

prettier

dc506b7

kevkevinpal reviewed Dec 22, 2023

View reviewed changes

frontend/app/src/people/widgetViews/parts/StatusPill.tsx Outdated Show resolved Hide resolved

changed GithubStatusPill to StatusPill

6202709

kevkevinpal reviewed Dec 22, 2023

View reviewed changes

gouravmpk added 2 commits December 23, 2023 03:00

removed status

3f68ecc

Merge branch 'stakwork:master' into mobileView-github

ede0973

ecurrencyhodler mentioned this pull request Dec 23, 2023

Add status components to mobile view #1182

Closed

3 tasks

kevkevinpal reviewed Dec 24, 2023

View reviewed changes

REMOVED commented part

128eb1b

kevkevinpal merged commit 3f7c62d into stakwork:master Dec 26, 2023
5 checks passed

ecurrencyhodler mentioned this pull request Jan 2, 2024

Remove code from mobile view of setting bounty status as open if github issue is open #1143

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove code from mobile view of setting bounty status as open if github issue is open #1164

Remove code from mobile view of setting bounty status as open if github issue is open #1164

gouravmpk commented Dec 21, 2023

kevkevinpal commented Dec 22, 2023

gouravmpk commented Dec 22, 2023

kevkevinpal Dec 22, 2023

kevkevinpal Dec 22, 2023

gouravmpk Dec 22, 2023 •

edited

Loading

ecurrencyhodler commented Dec 22, 2023

gouravmpk commented Dec 23, 2023

ecurrencyhodler commented Dec 23, 2023 •

edited

Loading

gouravmpk commented Dec 23, 2023

kevkevinpal commented Dec 24, 2023

kevkevinpal Dec 24, 2023

kevkevinpal commented Dec 24, 2023

gouravmpk commented Dec 24, 2023

gouravmpk commented Dec 24, 2023

kevkevinpal commented Dec 26, 2023

Remove code from mobile view of setting bounty status as open if github issue is open #1164

Remove code from mobile view of setting bounty status as open if github issue is open #1164

Conversation

gouravmpk commented Dec 21, 2023

Describe your changes

Issue ticket number and link

Checklist before requesting a review

Video

Note:

kevkevinpal commented Dec 22, 2023

gouravmpk commented Dec 22, 2023

kevkevinpal Dec 22, 2023

Choose a reason for hiding this comment

kevkevinpal Dec 22, 2023

Choose a reason for hiding this comment

gouravmpk Dec 22, 2023 • edited Loading

Choose a reason for hiding this comment

ecurrencyhodler commented Dec 22, 2023

gouravmpk commented Dec 23, 2023

ecurrencyhodler commented Dec 23, 2023 • edited Loading

gouravmpk commented Dec 23, 2023

kevkevinpal commented Dec 24, 2023

kevkevinpal Dec 24, 2023

Choose a reason for hiding this comment

kevkevinpal commented Dec 24, 2023

gouravmpk commented Dec 24, 2023

gouravmpk commented Dec 24, 2023

kevkevinpal commented Dec 26, 2023

gouravmpk Dec 22, 2023 •

edited

Loading

ecurrencyhodler commented Dec 23, 2023 •

edited

Loading