-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(issue #1010 and #1008):Implemented left and right arrow adjustments of timebox and date filters #1223
Conversation
looks like two tests are failing
|
frontend/app/src/pages/superadmin/tableComponent/TableComponent.Spec.tsx
Outdated
Show resolved
Hide resolved
I just gave this a light code review but it is looking good so far, you need to fix the tests but after we get those working I can do a manual test |
@kevkevinpal I have made some changes to the test files let's see if they pass also addressed the comments |
frontend/app/src/pages/superadmin/statistics/Statistics.spec.tsx
Outdated
Show resolved
Hide resolved
@kevkevinpal made the changes and updated the statistics test file |
Tested on staging and it works. REALLY nice job @Vayras . Paying you out now. |
…nts of timebox and date filters (#1223) * feat(issue #1010):Implement left and right arrow adjustments of timebox * fix(#1008):datefilters ui * fix(#1008):prettier * fix(#1008):updated test * PR fix * fix SuperAdminHeader.spec * fix attempt statistics test * fix attempt statistics test * fix for test * test fix * test fix * header test fix * prettier * header test fix * header test fix * test fix * header test * test fix * test fix * superadmin header test fix * final test fix * tested expected behaviour for stats
With This PR Changes:
-Left And Right arrow works correctly and helps you navigate the selected date range from date filters
-Date filters enables you to select a date range
-Test files have been updated
-pagination working correctly and only showing if there are more entries
video size is too big , shared on gdrive
https://drive.google.com/drive/folders/1U36os1AU8tAC0TvnvS0BYt-tipV0NFbM?usp=sharing
Tested on chrome , addresses #1010 #1008