Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue #1010 and #1008):Implemented left and right arrow adjustments of timebox and date filters #1223

Merged
merged 23 commits into from
Jan 3, 2024

Conversation

Vayras
Copy link
Contributor

@Vayras Vayras commented Dec 31, 2023

With This PR Changes:
-Left And Right arrow works correctly and helps you navigate the selected date range from date filters
-Date filters enables you to select a date range
-Test files have been updated
-pagination working correctly and only showing if there are more entries

video size is too big , shared on gdrive
https://drive.google.com/drive/folders/1U36os1AU8tAC0TvnvS0BYt-tipV0NFbM?usp=sharing

Tested on chrome , addresses #1010 #1008

@kevkevinpal
Copy link
Contributor

looks like two tests are failing


Summary of all failing tests
FAIL src/pages/superadmin/header/SuperAdminHeader.spec.tsx (13.752 s)
  ● Header Component › display header with extras

    expect(received).toBeInTheDocument()

    received value must be an HTMLElement or an SVGElement.
    Received has value: null

      37 |     );
      38 |
    > 39 |     expect(screen.queryByText(hardCodedDateRange)).toBeInTheDocument();
         |                                                    ^
      40 |     expect(screen.queryByText(exportCSVText)).toBeInTheDocument();
      41 |     expect(screen.queryByText(initDateRange)).toBeInTheDocument();
      42 |

      at __EXTERNAL_MATCHER_TRAP__ (node_modules/expect/build/index.js:386:30)
      at Object.throwingMatcher [as toBeInTheDocument] (node_modules/expect/build/index.js:387:15)
      at Object.<anonymous> (src/pages/superadmin/header/SuperAdminHeader.spec.tsx:39:52)

FAIL src/pages/superadmin/statistics/Statistics.spec.tsx
  ● Statistics Component › display about view with extras

    expect(received).toBeInTheDocument()

    received value must be an HTMLElement or an SVGElement.
    Received has value: null

      56 |     }
      57 |     for (let i = 0; i < hardcodedWords.length; i++) {
    > 58 |       expect(screen.queryByText(hardcodedWords[i])).toBeInTheDocument();
         |                                                     ^
      59 |     }
      60 |   });
      61 | });

      at __EXTERNAL_MATCHER_TRAP__ (node_modules/expect/build/index.js:386:30)
      at Object.throwingMatcher [as toBeInTheDocument] (node_modules/expect/build/index.js:387:15)
      at Object.<anonymous> (src/pages/superadmin/statistics/Statistics.spec.tsx:58:53)


Test Suites: 2 failed, 21 passed, 23 total
Tests:       2 failed, 71 passed, 73 total
Snapshots:   0 total
Time:        129.888 s
Ran all test suites.

@kevkevinpal
Copy link
Contributor

I just gave this a light code review but it is looking good so far, you need to fix the tests but after we get those working I can do a manual test

@Vayras
Copy link
Contributor Author

Vayras commented Jan 2, 2024

FAIL src/pages/superadmin/statistics/Statistics.spec.tsx
● Statistics Component › display about view with extras

expect(received).toBeInTheDocument()

received value must be an HTMLElement or an SVGElement.
Received has value: null

  56 |     }
  57 |     for (let i = 0; i < hardcodedWords.length; i++) {
> 58 |       expect(screen.queryByText(hardcodedWords[i])).toBeInTheDocument();
     |                                                     ^
  59 |     }
  60 |   });
  61 | });

  at __EXTERNAL_MATCHER_TRAP__ (node_modules/expect/build/index.js:386:30)
  at Object.throwingMatcher [as toBeInTheDocument] (node_modules/expect/build/index.js:387:15)
  at Object.<anonymous> (src/pages/superadmin/statistics/Statistics.spec.tsx:58:53)

@kevkevinpal I have made some changes to the test files let's see if they pass also addressed the comments

@Vayras
Copy link
Contributor Author

Vayras commented Jan 3, 2024

@kevkevinpal made the changes and updated the statistics test file

@kevkevinpal kevkevinpal merged commit f4953ed into stakwork:master Jan 3, 2024
5 checks passed
@ecurrencyhodler
Copy link
Contributor

Tested on staging and it works. REALLY nice job @Vayras . Paying you out now.

elraphty pushed a commit that referenced this pull request Jan 26, 2024
…nts of timebox and date filters (#1223)

* feat(issue #1010):Implement left and right arrow adjustments of timebox

* fix(#1008):datefilters ui

* fix(#1008):prettier

* fix(#1008):updated test

* PR fix

* fix SuperAdminHeader.spec

* fix attempt statistics test

* fix attempt statistics test

* fix for test

* test fix

* test fix

* header test fix

* prettier

* header test fix

* header test fix

* test fix

* header test

* test fix

* test fix

* superadmin header test fix

* final test fix

* tested expected behaviour for stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants