Create a test for pagination bar viewable in super admin

[ecurrencyhodler]

Create a component test to make sure pagination is visible

[hritikmunde]

@ecurrencyhodler , Can I work on this?

[ecurrencyhodler]

Yes absolutely. this is yours.

[ecurrencyhodler]

Did you sign up on our website yet? If so, what's your profile? https://community.sphinx.chat/bounties

[ecurrencyhodler]

Nvm found you!

[Vayras]

@ecurrencyhodler I Think This has been already addressed , I corrected this work while working on #1223

[ecurrencyhodler]

Okay. We can turn this bounty into a unit test then.

[ecurrencyhodler]

@hritikmunde we are going to change this issue into a unit test only. Once #1223 has been merged, you can begin working on this bounty.

[hritikmunde]

@ecurrencyhodler , okay got it.

[ecurrencyhodler]

@hritikmunde this is now ready to be worked on. You can grab the latest from master.

[hritikmunde]

@ecurrencyhodler , the tests for superAdmin are in the file TableComponent.Spec.tsx which has the wrong naming convention and is not in the folder __test__ which is where jest finds test cases according to the regex configured in file jest.config.js. To make a unit test for pagination I feel I should create a new file Pagination.spec.ts in the folder frontend\app\src\pages\superadmin\tableComponent\__test__ and add the test case there.

[kevkevinpal]

@ecurrencyhodler , the tests for superAdmin are in the file TableComponent.Spec.tsx which has the wrong naming convention and is not in the folder __test__ which is where jest finds test cases according to the regex configured in file jest.config.js. To make a unit test for pagination I feel I should create a new file Pagination.spec.ts in the folder frontend\app\src\pages\superadmin\tableComponent\__test__ and add the test case there.

I'm not seeing any reference to the __test__ path in here https://github.com/stakwork/sphinx-tribes/blob/master/frontend/app/jest.config.json could you point out where exactly in the file it is pointing to that?

[hritikmunde]

@ecurrencyhodler , the tests for superAdmin are in the file TableComponent.Spec.tsx which has the wrong naming convention and is not in the folder __test__ which is where jest finds test cases according to the regex configured in file jest.config.js. To make a unit test for pagination I feel I should create a new file Pagination.spec.ts in the folder frontend\app\src\pages\superadmin\tableComponent\__test__ and add the test case there.

I'm not seeing any reference to the __test__ path in here https://github.com/stakwork/sphinx-tribes/blob/master/frontend/app/jest.config.json could you point out where exactly in the file it is pointing to that?

I'm proposing to create a folder _test and create a new test file for pagination. What do you think?

[kevkevinpal]

@ecurrencyhodler , the tests for superAdmin are in the file TableComponent.Spec.tsx which has the wrong naming convention and is not in the folder __test__ which is where jest finds test cases according to the regex configured in file jest.config.js. To make a unit test for pagination I feel I should create a new file Pagination.spec.ts in the folder frontend\app\src\pages\superadmin\tableComponent\__test__ and add the test case there.

I realized you were right here, there seems to be a second jest.config.json file that specifies the __tests__ folder, I made some changes to move some tests into __tests__ folder

[kevkevinpal]

@ecurrencyhodler , the tests for superAdmin are in the file TableComponent.Spec.tsx which has the wrong naming convention and is not in the folder __test__ which is where jest finds test cases according to the regex configured in file jest.config.js. To make a unit test for pagination I feel I should create a new file Pagination.spec.ts in the folder frontend\app\src\pages\superadmin\tableComponent\__test__ and add the test case there.

I'm not seeing any reference to the __test__ path in here https://github.com/stakwork/sphinx-tribes/blob/master/frontend/app/jest.config.json could you point out where exactly in the file it is pointing to that?

I'm proposing to create a folder _test and create a new test file for pagination. What do you think?

Yea I have considered that before but I think that it makes it easier to create and validate tests if they are closer to the files they test. Please read this post for the comparison to the two approaches but I think it is best practice to keep the tests near the code you are testing

[hritikmunde]

@ecurrencyhodler , the tests for superAdmin are in the file TableComponent.Spec.tsx which has the wrong naming convention and is not in the folder __test__ which is where jest finds test cases according to the regex configured in file jest.config.js. To make a unit test for pagination I feel I should create a new file Pagination.spec.ts in the folder frontend\app\src\pages\superadmin\tableComponent\__test__ and add the test case there.

I realized you were right here, there seems to be a second jest.config.json file that specifies the __tests__ folder, I made some changes to move some tests into __tests__ folder

Yes I have added tests to that particular file. It's working will make changes needed in review

[ecurrencyhodler]

Closed by #1288