Test/pagination super admin #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevkevinpal , I'm having an issue with rendering MyTable and its css components. So I mocked the css using an empty file. Still, there is an error in HTML syntax. If you have any suggestions on this I would appreciate that. I'm working on it for now. |
…kmunde/sphinx-tribes into test/pagination-superAdmin
|
You have some jest and prettier tests failing. Can you check them plz? |
|
Yes I'm working on it. There are quite few changes and html syntax errors to be addressed. |
|
Hey @ecurrencyhodler , can I get a code review? It has a lot of changes and reverts too but I managed to add tests in |
|
All tests passed. GJ with that. Yes let's get a code review. |
kevkevinpal
reviewed
Jan 11, 2024
kevkevinpal
reviewed
Jan 11, 2024
|
@kevkevinpal , any other discrepancies found? Or changes needed to be made. @ecurrencyhodler , resolved the changes. |
|
paid |
elraphty
pushed a commit
that referenced
this pull request
Jan 26, 2024
* #1236 Added Organization Users unit test * Made changes for the mockFetch * made prettier changes * syntax and minor changes * #1233 Added test to check pagination. * Organization user conflict changes * removed mocked css line in PaginationView test * mock css added again * Ignore CSS Imports in Jest Configuration * added Alt text for pagination arrows * separated two <h2> styled elements. * mock data update * date format updated * <h2> child error changes * added mock bounties * changes * test changes * removed unnecessary files * removed excessive mock data * removed unncessary spaces --------- Co-authored-by: kevkevin <oapallikunnel@gmail.com>
elraphty
pushed a commit
that referenced
this pull request
Jan 26, 2024
* #1236 Added Organization Users unit test * Made changes for the mockFetch * made prettier changes * syntax and minor changes * #1233 Added test to check pagination. * Organization user conflict changes * removed mocked css line in PaginationView test * mock css added again * Ignore CSS Imports in Jest Configuration * added Alt text for pagination arrows * separated two <h2> styled elements. * mock data update * date format updated * <h2> child error changes * added mock bounties * changes * test changes * removed unnecessary files * removed excessive mock data * removed unncessary spaces --------- Co-authored-by: kevkevin <oapallikunnel@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Type of change
Please delete options that are not relevant.
Checklist before requesting a review