Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Translated the Home Page #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zivkovicmilos
Copy link

Translated the Home Page section of the React website into Serbian (Latin alphabet)

Copy link

@Milos5611 Milos5611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should first make a decision about how we treat keywords. Without that translation is not meaningful.

isOrdered: true
items:
- id: hello-world
title: Hello World
title: Zdravo, svete

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure shall we translate this into Serb
@vaske what do you think ?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should remain as Hello World

- id: lifting-state-up
title: Lifting State Up
title: Uzdizanje stanja naviše

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not uzdizanje but prenosenje.
Also stanje is a literal translation of state but here state means something else.
I think we should first define how we handle those keywords.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this, we should decide now at the beginning whether or not we're translating keywords like state, props, refs, reconciliation, etc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Milos5611 @vaske
I've looked around some other translations of the React website, it seems as though everybody has been translating state as variations of lokalni podaci, and props as ulazni podaci.
For stuff like refs, reconciliation and others, it's about 50/50. The French translation has them translated, whereas the German translation just left them as they were in English.

How do you guys propose we proceed? We need to figure this out quickly if we want to continue with the translations.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. For me state, props, refs, etc...are like var, const...reserved words.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pretty much agree with @Milos5611 in this situation I would rather keep it as it is, because in code you have to use it like that.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, we'll do it like that, then.
We'll treat them as reserved words, but where applicable explain in depth what they are (in the tutorial sections).
I'll refactor this code and commit it, so that you can merge it into the repo.

content/docs/nav.yml Outdated Show resolved Hide resolved
content/docs/nav.yml Outdated Show resolved Hide resolved
react-translations-bot pushed a commit that referenced this pull request Oct 10, 2022
* Added documentation for React.createFactory

* Update beta/src/content/apis/react/createFactory.md

Co-authored-by: Strek <ssharishkumar@gmail.com>

* minor editorial updates (#2)

* Update createFactory.md

* Update createFactory.md

* edits

Co-authored-by: Strek <ssharishkumar@gmail.com>
Co-authored-by: Holly Sweeney <77758406+holly1238@users.noreply.github.com>
Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants