-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse intermediate computations in distributions part 1 #1744
Conversation
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
@SteveBronder Is this something you'd like to tackle? |
If Steve is busy, I can tackle this one tomorrow. |
Idt I'll have time today but I will have time tmrw! Though looking at this I think @bbbales2 or other people better at stats stuff would be a better candidate to review this |
I'll do this tomorrow. Thanks for ping. Edit: Also careful with compliments. I'm superstitious on these pull reqs. I don't want a stats ghost to come haunt this and challenge my lowly skillz. |
Not much stat going on, only reshuffling of terms. When diffs are nice it's quite straightforward... but that's not often the case! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Summary
This is the first of a few PRs that aim to clean up the distributions so that we make better use of intermediate computations and composed functions.
This covers the following distributions:
Tests
None, this is just cleanup.
Side Effects
None.
Checklist
Math issue: Make use of composed functions and temporaries #1230
Copyright holder: Marco Colombo
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested