Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stan Math 3.2 release #1826

Closed
rok-cesnovar opened this issue Apr 4, 2020 · 10 comments
Closed

Stan Math 3.2 release #1826

rok-cesnovar opened this issue Apr 4, 2020 · 10 comments
Milestone

Comments

@rok-cesnovar
Copy link
Member

rok-cesnovar commented Apr 4, 2020

The next Math/Stan/Cmdstan/stanc3 release is scheduled for the 20th of April.
For Stan Math, the next release will be version 3.2.

We will once again have a feature freeze period that will start on the 13th of April.

@ everyone with merging rights: please dont merge any non-bugfix PRs until the release after the 13th of April. The closing of this issue will also serve as a mark that normal merging can continue.

This time we will also have a Cmdstan release candidate that will go out to a wider non-dev audiance. I dont think we need a Math release candidate, but if anyone feels that is necessary, please say so.

I am creating this issue for two reasons:

  • as a formal notification to all Math devs that there will be a feature freeze
  • to have a central topic for all thing related to the Math release. Please keep all release related discussion (release notes, urgent bugfixes, etc) in this topic. Last release we communicated on various PRs, Discourse topics, emails and it was confusing even for someone following closely.

There are a few open projects in the Math library. If anyone wants to make sure a PR is reviewed in time, feel free to write here.

Similar Stan/Cmdstan/stanc3 issue will be open soon (will edit the post to link them in).

@bbbales2
Copy link
Member

bbbales2 commented Apr 9, 2020

@rok-cesnovar I'm happy to write the release notes this round for math/stan/cmdstan if that's helpful.

I dunno if we ever incorporated any more process there. I'll just go around on April 13th and look through all the merges that happened since February 1st.

@rok-cesnovar
Copy link
Member Author

That would be fantastic. I should have a draft of things from the first month I will try to find and post here. The last week or so we started using the release notes so those should be simple. We will switch to scripts for the next release when all PRs will have the new Release notes sections.

Since Math is the vast majority of work we can split it and you write them for Math and I look at the rest.

Stan has like maybe 5 PRs, Cmdstan maybe 20 of which most are either mine or I was reviewing so that is easy for me. You cool with that?

@bbbales2
Copy link
Member

bbbales2 commented Apr 9, 2020

Since Math is the vast majority of work we can split it and you write them for Math and I look at the rest.

Sounds good!

@rok-cesnovar
Copy link
Member Author

@bbbales2 made great release notes. See stan-dev/stanc3#498 (comment)

@mitzimorris
Copy link
Member

just curious, why are math release nose in stanc3 repo?
also note, submitted a makefile PR to math yesterday.

@bbbales2
Copy link
Member

just curious, why are math release nose in stanc3 repo?

My mistake. I just vaguely knew there was an issue somewhere for the release, and I vaguely remembered there was a note that we were trying to keep stuff in one place. And so I found an issue here and put the notes here.

@SteveBronder
Copy link
Collaborator

SteveBronder commented Apr 16, 2020

Features

Contributor Title
t4c1 : (#1824) Add unary operations minus and logical negation to kernel generator
wds15 : (#1819) Feature/issue 1818 upgrade sundials 520
SteveBronder : (#1813) adds reduce_sum and tests
t4c1 : (#1802) Add extended kernel generator docs
t4c1 : (#1801) Add support for device functions to kernel generator
SteveBronder : (#1800) Adds auxilary functions needed for reduce_sum
t4c1 : (#1797) Add broadcasting to kernel generator
SteveBronder : (#1791) adds an apply function and cleans adj_jac_apply to use it
peterwicksstringfield : (#1780) Feature/elementwise check
bob-carpenter : (#1774) Feature/0123 complex funs
t4c1 : (#1769) Add transposition to kernel generator
t4c1 : (#1767) avoid redundant buffer allocations in kernel generator
t4c1 : (#1751) Allow kernel generator to calculate multiple outputs in single kernel
t4c1 : (#1740) Add colwise reductions to kernel generator
bob-carpenter : (#1736) Feature/1734 return scalar meta
andrjohns : (#1727) Eigen::Map and elementwise functions
t4c1 : (#1726) Bugfix common subexpression elimination in kernel generator
bob-carpenter : (#1720) Feature/0123 complex spec
mcol : (#1716) Add discrete_range_cdf, discrete_range_lcdf and discrete_range_lccdf
martinmodrak : (#1706) Using local_nested_autodiff for all instances of nested autodiff
mcol : (#1680) Add discrete_range_rng(lower, upper) and discrete_range_lpmf
wds15 : (#1675) avoid vari on chain-stack if var is constructed from an arithmetic type
martinmodrak : (#1657) Improved behavior of expect_near_rel
mcol : (#1650) Add reverse
mcol : (#1636) Add row vector, array and int_array construction utilities
t4c1 : (#1623) Add rowwise reductions to kernel generator
martinmodrak : (#1575) Additional tests for distributions
martinmodrak : (#1830) More stable implementation of neg_binomial_2_log_lpmf

Fixes

Contributor Title
mitzimorris : (#1842) Bugfix/1839 make shell linux
bob-carpenter : (#1837) return value type for complex abs; fixes #1836
bbbales2 : (#1834) Fix ode gradients with respect to t0 (Issue #1833)
rok-cesnovar : (#1825) Add licensing info to log_modified_bessel_first_kind
bbbales2 : (#1810) Added arithmetic version of pow (Fixes: #1809)
t4c1 : (#1807) fixed normal_id_glm for const sigma
rok-cesnovar : (#1795) Makefiles: Add $(strip) to findfiles function
SteveBronder : (#1794) Cleanup requires with macros
rok-cesnovar : (#1789) Reorganize Jenkins test stages
rok-cesnovar : (#1786) Add a release notes section in the pull request template
rok-cesnovar : (#1784) Makefiles: strip newlines in findiles and fix runChecks call
serban-nicusor-toptal : (#1777) Moved verify changes Jenkins step to shared libraries.
pgree : (#1772) Changed calculation of log_sum_exp(x1, x2)
peterwicksstringfield : (#1771) More documentation fixups.
SteveBronder : (#1768) [WIP][WIP] Add docs and generic value type signatures for reduce_sum
rok-cesnovar : (#1765) Cleanup duplicated overloads of scalar std:: functions
mcol : (#1762) Remove fwd versions of qr_Q and qr_R
mcol : (#1761) Move size_zero() calls after other consistency checks (L-Z)
mcol : (#1758) Move size_zero() calls after other consistency checks (A-I)
peterwicksstringfield : (#1756) Documentation fixups
t4c1 : (#1754) Generalize */fun starting with cr-d
t4c1 : (#1747) Generalize */fun startimg with chole-cov
mcol : (#1744) Reuse intermediate computations in distributions part 1
rok-cesnovar : (#1743) Update license.md year to 2020
t4c1 : (#1732) Generalize */fun starting with a-chol2
mcol : (#1730) Avoid 'Blocked loading mixed active content' errors
mcol : (#1728) Keep computations in log space and simplify expressions in beta binomial_*cdf
serban-nicusor-toptal : (#1724) Run CI/CD only on Source Code
pgree : (#1722) remove discontinuity in lub_constrain; fixes #1441
mcol : (#1718) Remove size zero checks from check_multiplicable
mcol : (#1717) Remove promote_common and common_type
mcol : (#1715) Cleanup mdivide_* and tests
rok-cesnovar : (#1712) fix develop
rok-cesnovar : (#1711) Bugfix/include what you use in /prim/fun
rok-cesnovar : (#1707) Add namespace qualifiers to size()
mcol : (#1705) Check for positive definiteness only after computing the LLT factors
mcol : (#1701) Don't throw when computing the inverse of a size zero matrix
mcol : (#1698) Improve tests and documentation for quad_form and quad_form_sym
mcol : (#1688) Add positive definite checks to mdivide_left_spd
mcol : (#1685) Allow multiply for size 0 inputs
kedartal : (#1684) Explicitly call stan::math::size (fix ambiguous call versus std::size)
mcol : (#1682) Check for consistent sizes before comparing arguments
mcol : (#1678) Reorganize files after flatten
mcol : (#1673) Remove Boost deprecation warning
mcol : (#1665) make develop build again
mcol : (#1663) correctness fixes in neg_binomial_* functions
mcol : (#1661) Move vectorize files to meta folder
t4c1 : (#1660) Generalize view and size functions
mcol : (#1655) Cleanup in poisson_cdf, poisson_lccdf and poisson_lcdf
serban-nicusor-toptal : (#1653) Fix permission denied in Jenkins pipeline
mcol : (#1649) Clean up code to use index_type_t, return_type_t and partials_return_t
t4c1 : (#1628) Generalize operator-like functions
martinmodrak : (#1614) Improved numerical stability of binomial_coefficient_log
rok-cesnovar : (#1567) Cleanup the use of find in makefile
SteveBronder : (#1525) Generic var templates for operators and std::iterator_trait var/fvar specialization
martinmodrak : (#1497) Fixing negative binomial phi cutoff
t4c1 : (#1796) Bugfix: make kernel generator wait for events on matrices
mcol : (#1674) Document template parameters in /prim
mcol : (#1668) Rename spaced_* to linspaced_*
wds15 : (#1821) clarify README.md

@rok-cesnovar
Copy link
Member Author

rok-cesnovar commented Apr 22, 2020

Once the green light will be given (on Discourse) please start with the release @serban-nicusor-toptal. Here are the Math/Stan release notes again

Stan Math release notes: stan-dev/stanc3#498 (comment)

Stan release notes:

- updated Stan Math to 3.2
- `rvalue` and `assign` now accept generic Eigen expressions

Will post Cmdstan release notes in stan-dev/cmdstan#852

@rok-cesnovar
Copy link
Member Author

Math 3.2 was released. Thanks @serban-nicusor-toptal !

This is also a mark that the feature freeze is over in Math and Stan. If you can hold off for a few more hours to let Jenkins breathe a bit. But merge away.

Also feel free to comment on the release process if you want in this thread even if closed.

@mitzimorris
Copy link
Member

I think doing these release candidates was worth the extra overhead.

@mcol mcol added this to the 3.2.0 milestone May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants