-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify README.md #1821
clarify README.md #1821
Conversation
…gs/RELEASE_500/final)
…an-dev/math into feature/issue-1820-fix-readme
…stable/2017-11-14)
spelling fix
…gs/RELEASE_500/final)
Hopefully Jenkins will not change back this formatting thing (which pops up in all PRs right now for whatever reason). |
Yes some Jenkins workers have clang-format 5.0.0 and some have 6.0.0 and they differ in some details and that needs to be sorted out. I will make an issue and assign Nic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THe changes look good to me.
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
Summary
Adapt README.md to our new logic of instructions.
Tests
Side Effects
Release notes
clarify README.md
Checklist
Math issue Update README.md #1820
Copyright holder: Sebastian Weber
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested