Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved verify changes from Jenkinsfile to Shared Libraries. #2905

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

serban-nicusor-toptal
Copy link
Contributor

Submission Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

This PR removes code that was moved into the Shared Libraries while also fixing a bug reported in
stan-dev/math#1773

Intended Effect

How to Verify

Side Effects

Documentation

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 4.84 4.93 0.98 -1.89% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.97 -2.78% slower
eight_schools/eight_schools.stan 0.09 0.09 0.99 -0.86% slower
gp_regr/gp_regr.stan 0.22 0.22 1.0 0.26% faster
irt_2pl/irt_2pl.stan 6.45 6.45 1.0 0.08% faster
performance.compilation 87.4 86.74 1.01 0.76% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 7.61 7.58 1.0 0.31% faster
pkpd/one_comp_mm_elim_abs.stan 21.51 21.13 1.02 1.73% faster
sir/sir.stan 92.92 94.24 0.99 -1.42% slower
gp_regr/gen_gp_data.stan 0.05 0.05 0.97 -3.31% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan 2.95 2.95 1.0 -0.1% slower
pkpd/sim_one_comp_mm_elim_abs.stan 0.33 0.31 1.07 6.26% faster
arK/arK.stan 1.75 1.9 0.92 -8.66% slower
arma/arma.stan 0.67 0.66 1.0 0.48% faster
garch/garch.stan 0.51 0.52 0.99 -0.53% slower
Mean result: 0.99447673811

Jenkins Console Log
Blue Ocean
Commit hash: 966907b


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@serban-nicusor-toptal serban-nicusor-toptal merged commit 7097035 into develop Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants