Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release the ESLint 8 version #73

Closed
voxpelli opened this issue Apr 25, 2022 · 16 comments
Closed

Release the ESLint 8 version #73

voxpelli opened this issue Apr 25, 2022 · 16 comments

Comments

@voxpelli
Copy link
Member

It's been requested in: #69

See also: standard/eslint-config-standard#229

@framerate
Copy link

Please!

@fnwbr
Copy link

fnwbr commented Jun 13, 2022

At medienhaus/ we've started using the workaround to specify a git commit hash as the version for the npm package. Since the issue was basically fixed on the master branch and we're all just waiting for the release on npm for it, this will solve the problem (and potential issues with npm install) in the meantime:
medienhaus/medienhaus-cms@9f00f9c

@derekhubbard
Copy link

Any update on this? Until this is fixed, I don't see a clean path forward to us using the latest version of node and npm due to invalid peer dependency checks.

@voxpelli
Copy link
Member Author

I'm a bit choked right now, but I will have some discussions on this subject tomorrow, I may come back after that and see

@voxpelli
Copy link
Member Author

Also, you probably want to use eslint-config-standard-jsx instead of this one. That's why this wasn't included in the major releases of standard@17, because standard itself uses eslint-config-standard-jsx and it's a bit unclear to me whether this module is actually deprecated by that one or not.

@voxpelli
Copy link
Member Author

Note to self:

From the looks of it this is a straight extension on top of the jsx one: c357387

BREAKING: Stop extending from eslint-config-standard-jsx

To update, you will need to:

npm install eslint-config-standard-jsx

And then ensure that "standard-jsx" appears in the "extends" section of your .eslintrc:

"extends": [
"standard-react", "standard-jsx"
]

@flippidippi
Copy link

Note to self:

From the looks of it this is a straight extension on top of the jsx one: c357387

BREAKING: Stop extending from eslint-config-standard-jsx
To update, you will need to:
npm install eslint-config-standard-jsx
And then ensure that "standard-jsx" appears in the "extends" section of your .eslintrc:
"extends": [
"standard-react", "standard-jsx"
]

I agree. I feel like these rules should be rolled into eslint-config-standard-jsx

@voxpelli
Copy link
Member Author

@flippidippi The rules in eslint-config-standard-react are the React specific ones on top of the basic JSX ones, so they can't be added to eslint-config-standard-jsx.

Whether it's meaningful to maintain in addition to eslint-config-standard-jsx and possibly creating confusion in how to use them: That can be discussed

@JounQin
Copy link

JounQin commented Jul 7, 2022

When will this be released??

@mirismaili
Copy link

When will this be released???

@flippidippi
Copy link

Can we just release this for now until we figure out the jsx vs react direction? I think it makes sense to consolidate those, but until that's done, I feel like this should just be released as is so people can upgrade to 8.

@framerate
Copy link

@flippidippi I fear most of us have just moved on to other solutions, this project almost appears abandoned. But hopefully somebody proves me wrong! Big fan

@mkasprz
Copy link

mkasprz commented Oct 28, 2022

Without the release I feel forced to pull version directly from Github as otherwise I expeced some conflict with some other package (I'm not sure which one now, but possibly "@babel/eslint-parser"). Would be grateful for it.

@s100
Copy link

s100 commented Oct 28, 2022

It's been six months, this obviously isn't coming. I suggest just stopping using this package.

@voxpelli
Copy link
Member Author

Released as 12.0.0, though I don't use this one myself so please report any bugs back

@mkasprz
Copy link

mkasprz commented Oct 28, 2022

Great, thank You!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

9 participants