Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support ESLint 8.x #69

Merged
merged 1 commit into from
Mar 1, 2022
Merged

feat: support ESLint 8.x #69

merged 1 commit into from
Mar 1, 2022

Conversation

KKoukiou
Copy link
Contributor

Fixes #68

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[X] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)
Update needed dependencies and tests

Which issue (if any) does this pull request address?
Support ESlint 8.x

Is there anything you'd like reviewers to focus on?

@welcome
Copy link

welcome bot commented Feb 11, 2022

🙌 Thanks for opening this pull request! You're awesome.

@KKoukiou KKoukiou mentioned this pull request Feb 15, 2022
Closed
theoludwig
theoludwig approved these changes Feb 18, 2022
View reviewed changes
Copy link

@theoludwig theoludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. 😄
LGTM! 👍

LinusU
LinusU approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚀

@52541
Copy link

52541 commented Feb 28, 2022

What can I do to help? I will try.

@KKoukiou
Copy link
Contributor Author

KKoukiou commented Mar 1, 2022

Hi :) can i help to get this unblocked? It's prohibiting consumer projects to start using ESLint 8.x.

@theoludwig theoludwig merged commit 78895ee into standard:master Mar 1, 2022
@welcome
Copy link

welcome bot commented Mar 1, 2022

🎉 Congrats on getting your first pull request landed!

@theoludwig
Copy link

Hi :) can i help to get this unblocked? It's prohibiting consumer projects to start using ESLint 8.x.

Merged, thanks again for your contribution! 😄
But I can't release.

@KKoukiou KKoukiou deleted the eslint-8 branch March 1, 2022 15:23
@theoludwig theoludwig mentioned this pull request Mar 18, 2022
Closed
KKoukiou added a commit to KKoukiou/starter-kit that referenced this pull request Apr 9, 2022
@KKoukiou
package.json: bump eslint to ^8.0.0 and all eslint-x dependencies
c44587c 
So as to satisfy the new eslint peer dependency.

In addition drop eslint-config-standard-react as it does not release
anymore, and eslint 8.x is not compatible with the available last
release.
standard/eslint-config-standard-react#69

Replace it with https://github.com/facebook/create-react-app#readme
which is actively maintained.

Lastly drop the deprecated
https://github.com/standard/eslint-plugin-standard
@KKoukiou KKoukiou mentioned this pull request Apr 9, 2022
Merged
martinpitt pushed a commit to KKoukiou/starter-kit that referenced this pull request Apr 11, 2022
@KKoukiou @martinpitt
package.json: bump eslint to ^8.0.0 and all eslint-x dependencies
3d490c6 
So as to satisfy the new eslint peer dependency.

In addition drop eslint-config-standard-react as it does not release
anymore, and eslint 8.x is not compatible with the available last
release.
standard/eslint-config-standard-react#69

Replace it with https://github.com/facebook/create-react-app#readme
which is actively maintained.

Lastly drop the deprecated
https://github.com/standard/eslint-plugin-standard
martinpitt pushed a commit to cockpit-project/starter-kit that referenced this pull request Apr 11, 2022
@KKoukiou @martinpitt
package.json: bump eslint to ^8.0.0 and all eslint-x dependencies
fe1a9a3 
So as to satisfy the new eslint peer dependency.

In addition drop eslint-config-standard-react as it does not release
anymore, and eslint 8.x is not compatible with the available last
release.
standard/eslint-config-standard-react#69

Replace it with https://github.com/facebook/create-react-app#readme
which is actively maintained.

Lastly drop the deprecated
https://github.com/standard/eslint-plugin-standard
@boennemann
Copy link

Thanks for this PR! Is there any plan to release this to npm soon? It's a pitty this is sitting around on the main branch and it can't be used 😬

@voxpelli
Copy link
Member

@boennemann My impression is that this module is deprecated 🤔 The standard module instead uses the eslint-config-standard-jsx one, hence why I didn’t roll a release of this one.

I’m tracking some of the remaining releases here: standard/eslint-config-standard#229

@pjg
Copy link

pjg commented Apr 23, 2022 •
edited
Loading

@voxpelli I don't think eslint-config-standard-jsx fully replaces eslint-config-standard-react. From eslint-config-standard-jsx README:

Even though this config is JSX only (no React), it makes use of eslint-plugin-react for its generic JSX rules.

(If you want React-specific rules too, consider using eslint-config-standard-react instead.)

EDIT: I compared the rules in both packages and they are completely different, so I don’t think eslint-config-standard-react is deprecated in any way. It complements eslint-config-standard-jsx. As such, any chance for an official npm release?

@mirismaili
Copy link

mirismaili commented Apr 25, 2022 •
edited
Loading

The current version on NPM (v11.0.1 that is published a year ago) doesn't support ESLint 8 yet! Even there is no beta version.

@voxpelli voxpelli mentioned this pull request Apr 25, 2022
Closed
@voxpelli
Copy link
Member

I created an issue for it: #73

msedo8g8
msedo8g8 reviewed Apr 29, 2022
View reviewed changes
Copy link

@msedo8g8 msedo8g8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fucc

@derekhubbard
Copy link

Hey folks, just checking in. Any idea what the hold-up is in getting the released? Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msedo8g8 msedo8g8 msedo8g8 left review comments

@theoludwig theoludwig theoludwig approved these changes

@LinusU LinusU LinusU approved these changes

@voxpelli voxpelli Awaiting requested review from voxpelli

Assignees
No one assigned
Labels
None yet
Projects
The Standard Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support ESLint 8
10 participants
@KKoukiou @52541 @theoludwig @boennemann @voxpelli @pjg @mirismaili @derekhubbard @LinusU @msedo8g8