Instantiate Object-type lint_roller plugins correctly #557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were instantiating configuration objects from plugins using
RuboCop::Config.new
instead ofRuboCop::Config.create
, which ended up causing subtle differences in howAllCops
was being handled when merging plugins. Namely, it resulted in the inclusion of any such plugin as disabling all previously-defined cops, which is not what we'd want. (Including a single empty object plugin in your config will effectively disable every built-in cop, which isn't super good).It still feels like there's more underlying trouble here around
AllCops
optionDisabledByDefault
which was added in 1.28.0, but this will fix the immediate and urgent issue.Fixes standardrb/standard-rails#4