Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instantiate Object-type lint_roller plugins correctly #557

Merged
merged 3 commits into from
May 1, 2023
Merged

Instantiate Object-type lint_roller plugins correctly #557

merged 3 commits into from
May 1, 2023

Commits on May 1, 2023

  1. Create object configs the same way RuboCop would 

    By supplying a path and calling Config.create, plugins that publish an :object type rules config will correctly merge in AllCops settings, such that everything seems to work.

Fixes: standardrb/standard-rails#4

This breaks a lot of tests and emits a lot of warnings, so we still have to work through those
    @searls
    searls committed May 1, 2023
    Configuration menu
    Copy the full SHA
    950f012 View commit details
    Browse the repository at this point in the history

  2. Add a test for the merging issue. 

    The reason this covers the problem is that it demonstrates the base configuration is still intact even though an object-type lint_roller plugin is also active.
    @searls
    searls committed May 1, 2023
    Configuration menu
    Copy the full SHA
    127f54d View commit details
    Browse the repository at this point in the history

  3. Fix the build by surviving config validation 

    This still emits a bunch of warnings, which sucks.
    @searls
    searls committed May 1, 2023
    Configuration menu
    Copy the full SHA
    2c379da View commit details
    Browse the repository at this point in the history