Fix intermediate state where newly gen frontmatter wasn't saved yet #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adambabik
approved these changes
Apr 18, 2024
internal/document/frontmatter.go
Outdated
| func (f *Frontmatter) Marshal(requireIdentity bool) ([]byte, error) { | ||
| // Marshal returns a marshaled frontmatter including triple-dashed lines and a document ID. | ||
| // If the identity is required, but Frontmatter is nil, a new one including ID is created. | ||
| func (f *Frontmatter) Marshal(requireIdentity bool) ([]byte, string, error) { |
There was a problem hiding this comment.
Remark: In the ideal world we would strive for following signature: Marshal() ([]byte, error).
There was a problem hiding this comment.
I know, but it would require me to rethink/rewrite a large part of the prepopulating frontmatter scenario which makes other things super complicated.
There was a problem hiding this comment.
Still need to do more integration testing with the extension before committing to this change, fwiw.
Thanks for the review!
|
sourishkrout
force-pushed
the
seb-fix-ephem
branch
from
7deab68
to
5d6a408
Compare
|
|
Obsolete as of #677. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also simplifies logic when document-level lifecycle identity (i.e. doc ID) is turned off.