Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear relationship between ephemeral and persistent lifecycle IDs #677

Merged
merged 6 commits into from
Oct 4, 2024

Conversation

sourishkrout
Copy link
Member

@sourishkrout sourishkrout commented Oct 1, 2024

When we first introduced lifecycle identity, it was designed to turn persistence on or off at build time. The following changes will ideally allow clients to toggle persistence dynamically.

  1. Always use ephemeral IDs if there are no persistent IDs in the document/node models.
  2. Decide persistence exclusively at deserialization time in the Parser.

I have cleaned up runme fmt as part of these changes, changed to run code-server in docker-only (avoid rate limiting locally), and made runme terminal stop flaking when run inside of Docker.

@sourishkrout sourishkrout marked this pull request as draft October 1, 2024 15:50
@sourishkrout
Copy link
Member Author

The next thing to figure out is if it makes sense to harvest some of #558 into this PR.

@sourishkrout
Copy link
Member Author

The next thing to figure out is if it makes sense to harvest some of #558 into this PR.

Based on my findings, I think we should forgo #558 because it does not solve the problem on the extension side.

Copy link

sonarcloud bot commented Oct 2, 2024

@sourishkrout sourishkrout merged commit f6dd7a2 into main Oct 4, 2024
5 of 6 checks passed
@sourishkrout sourishkrout deleted the seb/lcid branch October 4, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant