Fix yet another epoch slot issue #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnetheduck
reviewed
Feb 19, 2019
| notice "Unexpected block slot number - stackTrace incoming", | ||
| blockSlot = humaneSlotNum blck.slot, | ||
| stateSlot = humaneSlotNum state.slot | ||
| writeStackTrace() |
| @@ -397,23 +399,29 @@ proc processBlock( | |||
| return false | |||
|
|
|||
| if not processRandao(state, blck, flags): | |||
| notice "Randao failure" | |||
There was a problem hiding this comment.
these should already log at the error site, with more pertinent information (where the initial error is detected)
| debug "TRACE - updateState", | ||
| oldStateSlot = humaneSlotNum state.slot, | ||
| proposedBlockSlot = if new_block.isSome(): new_block.get.slot.humaneSlotNum | ||
| else: 1010101010 |
| addTimer(at) do (p: pointer): | ||
| # Chronicles is not GC-safe | ||
| debugEcho "TRACE - in closure: currentSlot ", humaneSlotNum node.beaconState.slot |
|
#125 probably fixes this issue |
|
Actually I wanted to get more input from @zah to make sure the copy was still needed, hence I left the debug output so that he can reproduce and check. |
etan-status
pushed a commit
that referenced
this pull request
May 12, 2022
Deprecated asyncDiscard() procedure. Bump version to 2.5.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #101 and add several more tracing, the gist of it is that we were making our updates on a copy of our state.
It does not seem like the copy is needed anymore (pending CI).
In summary I think that this goes one step beyond the branch https://github.com/status-im/nim-beacon-chain/tree/yglukhov-somewhat-stable-simulation
I definitely felt the tangle while trying to debug it (cf: #117 (comment)). I think we need a refactoring as soon as phase 0 stabilizes.
Next steps
Note that we still have block slot issues, but the new one seems to need moving or reordering core part of the processing as we:
With the assert being at the soon infamous :) "Could this fail somehow"
https://github.com/status-im/nim-beacon-chain/blob/e1efdd4349a35903861a5384df0a96f07005fa56/beacon_chain/beacon_node.nim#L220-L229