Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

naive attestation pool, in preparation of fork choice integration #125

Merged
merged 1 commit into from
Feb 19, 2019
Merged

naive attestation pool, in preparation of fork choice integration #125

merged 1 commit into from
Feb 19, 2019

Conversation

arnetheduck
Copy link
Member

  • move attestation pool to separate file
  • combine attestations lazily when needed
  • advance state when there's a gap while attesting
  • compile beacon node with optimizations - it's tooo slow right now
  • log when unable to keep up

@arnetheduck
naive attestation pool, in preparation of fork choice integration
8ec9a8f 
* move attestation pool to separate file
* combine attestations lazily when needed
* advance state when there's a gap while attesting
* compile beacon node with optimizations - it's tooo slow right now
* log when unable to keep up
tersec
tersec approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@tersec tersec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like that it splits out attestation_pool.nim from fork_choice.nim. It has caveats, but you've noted some of them -- and the others should go in a separate PR, since I regard this as a good-enough improvement on the status quo.

@arnetheduck arnetheduck mentioned this pull request Feb 19, 2019
Closed
mratsim
mratsim approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@mratsim mratsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mratsim mratsim mentioned this pull request Feb 19, 2019
Closed
@mratsim mratsim merged commit 4670d6c into master Feb 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the attestation-pool branch February 19, 2019 23:35
etan-status pushed a commit that referenced this pull request May 12, 2022
@cheatfate
Fix newFuture[T] location source for generated async procedures. (#125)
126ea4b 
Add tests to for locations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mratsim mratsim mratsim approved these changes

@tersec tersec tersec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arnetheduck @tersec @mratsim