Fix disconnect race. #2088
Open
Fix disconnect race. #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdeme
reviewed
Nov 26, 2020
cheatfate
force-pushed
the
disconnect-race-fix
branch
from
11ead9d
to
ee0a025
Compare
arnetheduck
reviewed
Mar 15, 2021
beacon_chain/eth2_network.nim
Outdated
| # All the `peer.disconnectedFut` callbacks are already scheduled in current | ||
| # `poll()` call, to avoid race we going to finish only in next `poll()` | ||
| # call. | ||
| callSoon(continuation, cast[pointer](retFuture)) |
There was a problem hiding this comment.
the pointer isn't needed here
Add isAlive(peer) procedure. Add join(peer) procedure. Remove useless metric. Add notifyAndWait() procedure which will help to avoid race while disconnecting.
notifyAndWait() now waits PeerPool and disconnection.
cheatfate
force-pushed
the
disconnect-race-fix
branch
from
ee0a025
to
4957ae8
Compare
arnetheduck
reviewed
Nov 25, 2021
| block: | ||
| var fut0 = pool.joinPeer(peer0) | ||
| doAssert(fut0.finished == false) | ||
| await sleepAsync(20.milliseconds) |
There was a problem hiding this comment.
can't we use the step polling here instead?
arnetheduck
reviewed
Dec 3, 2021
| if not(isNil(fut)): | ||
| fut.complete() | ||
| peer.disconnectedFut = nil | ||
| if not(isNil(peer.disconnectedFut)): |
There was a problem hiding this comment.
shouldn't this check be inside notifyAndWait?
arnetheduck
reviewed
Dec 3, 2021
| # All the `peer.disconnectedFut` callbacks are already scheduled in current | ||
| # `poll()` call, to avoid race we going to finish only in next `poll()` | ||
| # call. | ||
| callSoon(continuation, cast[pointer](retFuture)) |
There was a problem hiding this comment.
continuation does not use its udata pointer - why include a pointer here?
arnetheduck
force-pushed
the
unstable
branch
2 times, most recently
from
657f9d5
to
a4667d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PeerPoolto usegetFuture()only once when adding peer.isAlive(peer)procedure.join(peer)procedure.notifyAndWait()procedure which will help to avoid race while disconnecting.