Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix disconnect race. #2088

Open
wants to merge 4 commits into
base: unstable
Choose a base branch
from
Open

Fix disconnect race. #2088

wants to merge 4 commits into from

Commits on Nov 18, 2021

  1. Fix PeerPool to use getFuture() only once when adding peer. 

    Add isAlive(peer) procedure.
Add join(peer) procedure.
Remove useless metric.
Add notifyAndWait() procedure which will help to avoid race while disconnecting.
    @cheatfate
    cheatfate committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    830f125 View commit details
    Browse the repository at this point in the history

  2. Fix PeerPool tests.

    @cheatfate
    cheatfate committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    a0c547f View commit details
    Browse the repository at this point in the history

  3. Add peerpool.joinPeer() and tests. 

    notifyAndWait() now waits PeerPool and disconnection.
    @cheatfate
    cheatfate committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    afd0754 View commit details
    Browse the repository at this point in the history

  4. Post-rebase fixes.

    @cheatfate
    cheatfate committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    4957ae8 View commit details
    Browse the repository at this point in the history