-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bridge replies don't show as replies from Status to Discord #16323
Labels
Milestone
Comments
jrainville
added
bug
Something isn't working
E:Desktop Bridge Status Discord
core-team
labels
Sep 11, 2024
jrainville
added a commit
to status-im/matterbridge
that referenced
this issue
Sep 12, 2024
Needed for status-im/status-desktop#16323 There were multiple problems. 1. The ParentID was not set correctly when a message was sent from Status 2. We didn't send back the ID of messages that we sent, so the gateway couldn't associate the new messages to the old ones 3. Missing param in the toml config `PreserveThreading` 4. Discord messages are weirdly formatted when a reply is send. It cannot use webhooks, so we need to pass the username directly in the message (it's ugly, but it works) Finally, there was an issue on the status-go side. We tried to use the discord message ID to find the replies, but the bridge already converts it to the right ID, so we could just use it directly
jrainville
added a commit
to status-im/status-go
that referenced
this issue
Sep 12, 2024
Fixes status-im/status-desktop#16323 The problem was that the code expected to receive the Discord message ID, but the bridge is smart enough to return the Status message ID already, so there is no need to try and convert it. There were also a couple issues in the bridge code itself.
jrainville
added a commit
to status-im/status-go
that referenced
this issue
Sep 12, 2024
Fixes status-im/status-desktop#16323 The problem was that the code expected to receive the Discord message ID, but the bridge is smart enough to return the Status message ID already, so there is no need to try and convert it. There were also a couple issues in the bridge code itself.
jrainville
added a commit
to status-im/status-go
that referenced
this issue
Sep 12, 2024
Fixes status-im/status-desktop#16323 The problem was that the code expected to receive the Discord message ID, but the bridge is smart enough to return the Status message ID already, so there is no need to try and convert it. There were also a couple issues in the bridge code itself.
jrainville
added a commit
to status-im/status-go
that referenced
this issue
Sep 13, 2024
Fixes status-im/status-desktop#16323 The problem was that the code expected to receive the Discord message ID, but the bridge is smart enough to return the Status message ID already, so there is no need to try and convert it. There were also a couple issues in the bridge code itself.
siddarthkay
pushed a commit
to status-im/matterbridge
that referenced
this issue
Sep 14, 2024
Needed for status-im/status-desktop#16323 There were multiple problems. 1. The ParentID was not set correctly when a message was sent from Status 2. We didn't send back the ID of messages that we sent, so the gateway couldn't associate the new messages to the old ones 3. Missing param in the toml config `PreserveThreading` 4. Discord messages are weirdly formatted when a reply is send. It cannot use webhooks, so we need to pass the username directly in the message (it's ugly, but it works) Finally, there was an issue on the status-go side. We tried to use the discord message ID to find the replies, but the bridge already converts it to the right ID, so we could just use it directly
jrainville
added a commit
to status-im/status-go
that referenced
this issue
Sep 23, 2024
Fixes status-im/status-desktop#16323 The problem was that the code expected to receive the Discord message ID, but the bridge is smart enough to return the Status message ID already, so there is no need to try and convert it. There were also a couple issues in the bridge code itself.
jrainville
added a commit
to status-im/status-go
that referenced
this issue
Sep 24, 2024
Fixes status-im/status-desktop#16323 The problem was that the code expected to receive the Discord message ID, but the bridge is smart enough to return the Status message ID already, so there is no need to try and convert it. There were also a couple issues in the bridge code itself.
jrainville
added a commit
to status-im/status-go
that referenced
this issue
Sep 27, 2024
Fixes status-im/status-desktop#16323 The problem was that the code expected to receive the Discord message ID, but the bridge is smart enough to return the Status message ID already, so there is no need to try and convert it. There were also a couple issues in the bridge code itself.
github-project-automation
bot
moved this from Code Review
to Done
in Status Desktop/Mobile Board
Sep 27, 2024
github-project-automation
bot
moved this from Code Review
to Done
in Status Desktop/Mobile Board
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
Description
When you do a reply on Status, the message on Discord doesn't show as a reply, just like a normal message.
When sending a reply from Discord however, it works fine.
Steps to reproduce
Expected behavior
The message shows a a reply on both platforms
Actual behavior
The message shows as a reply only on Status. It shows as a normal message on Discord
Additional Information
The text was updated successfully, but these errors were encountered: