Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review token price cache initialization #9453

Closed
dlipicar opened this issue Feb 6, 2023 · 0 comments · Fixed by #9547
Closed

Review token price cache initialization #9453

dlipicar opened this issue Feb 6, 2023 · 0 comments · Fixed by #9547
Assignees
@dlipicar
Labels
bug Something isn't working
Milestone
0.11.0

Comments

@dlipicar
Copy link
Contributor

dlipicar commented Feb 6, 2023

Description

See https://github.com/status-im/status-desktop/pull/9330/files#r1097228717

Token price cache initialization logic was changed as part of a bugfix. I believe that specific change should not be necessary. Revert that line and test to see it does not impact functionality.
@dlipicar dlipicar added bug Something isn't working Wallet labels Feb 6, 2023
@dlipicar dlipicar self-assigned this Feb 6, 2023
@alaibe alaibe added this to the 0.11.0 milestone Feb 8, 2023
@dlipicar dlipicar mentioned this issue Feb 14, 2023
Merged
dlipicar added a commit that referenced this issue Feb 14, 2023
@dlipicar
feat(@desktop/Wallet): use new status-go currency formatting API
4497e55 
Fixes #9453
dlipicar added a commit that referenced this issue Feb 14, 2023
@dlipicar
feat(@desktop/Wallet): use new status-go currency formatting API
3e51d32 
Fixes #9453
@dlipicar dlipicar mentioned this issue Feb 14, 2023
Merged
dlipicar added a commit that referenced this issue Feb 17, 2023
@dlipicar
feat(@desktop/Wallet): use new status-go currency formatting API
18afc96 
Fixes #9453
dlipicar added a commit that referenced this issue Feb 17, 2023
@dlipicar
feat(@desktop/Wallet): use new status-go currency formatting API
1347bb7 
Fixes #9453
dlipicar added a commit that referenced this issue Feb 17, 2023
@dlipicar
feat(@desktop/Wallet): use new status-go currency formatting API
72ff8b3 
Fixes #9453
dlipicar added a commit that referenced this issue Feb 17, 2023
@dlipicar
feat(@desktop/Wallet): use new status-go currency formatting API
27b8180 
Fixes #9453
iurimatias pushed a commit that referenced this issue Feb 24, 2023
@dlipicar @iurimatias
feat(@desktop/Wallet): use new status-go currency formatting API
2447272 
Fixes #9453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dlipicar dlipicar

Labels
bug Something isn't working
Projects
Status Desktop/Mobile Board
Archived in project
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

feat(@desktop/Wallet): use new status-go currency formatting API status-im/status-desktop
2 participants
@alaibe @dlipicar