feat(@desktop/Wallet): use new status-go currency formatting API #9547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlipicar
requested review from
saledjenic,
Khushboo-dev-cpp,
stefandunca,
igor-sirotin and
alaibe
dlipicar
requested review from
IvanBelyakoff
and removed request for
igor-sirotin
Jenkins BuildsClick to see older builds (7)
|
stefandunca
approved these changes
Feb 17, 2023
saledjenic
approved these changes
Feb 17, 2023
dlipicar
force-pushed
the
feat/9453-move-tcurrency-formatting-to-status-go
branch
2 times, most recently
from
18afc96
to
1347bb7
Compare
dlipicar
force-pushed
the
feat/9453-move-tcurrency-formatting-to-status-go
branch
from
1347bb7
to
72ff8b3
Compare
4 tasks
dlipicar
deleted the
feat/9453-move-tcurrency-formatting-to-status-go
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9453
Deprecates #9191
What does the PR do
Make use of the new status-go currency formatting API.
Most currency formatting functionality was moved to status-go, so it is removed from the client.
Nim is now only in charge of getting the format table and triggering a refresh.
When the formats are updated, every module which contains a
CurrencyAmountobject should refresh it. This was done for all modules except for the Activity tab, which requires a bit extra work (see #9548).