Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Community): Community messaging statistics chart #11696

Merged
merged 5 commits into from
Aug 2, 2023
Merged

feat(Community): Community messaging statistics chart #11696

merged 5 commits into from
Aug 2, 2023

Conversation

MishkaRogachev
Copy link
Contributor

@MishkaRogachev MishkaRogachev commented Jul 27, 2023 •
edited
Loading

Close #11152
Waits status-im/status-go#3802

What does the PR do

  • Use of collectCommunityMessageMetrics for messaging statistics chart in community overview
  • Basic chart data caching

Affected areas

Communities

Screenshot of functionality (including design for comparison)

Screen.Recording.2023-08-02.at.18.14.36.mov

@MishkaRogachev MishkaRogachev linked an issue Jul 27, 2023 that may be closed by this pull request
[Community Management] Implement nb of members graph (backend) #11152
Closed
@status-im-auto
Copy link
Member

status-im-auto commented Jul 27, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (61)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 441e485 #1 2023-07-27 16:54:55 ~4 min tests/imports 📄log
✔️ 441e485 #1 2023-07-27 16:55:58 ~5 min tests/nim 📄log
✔️ 441e485 #1 2023-07-27 16:58:01 ~7 min macos/aarch64 🍎dmg
✔️ 441e485 #1 2023-07-27 17:00:39 ~10 min macos/x86_64 🍎dmg
✔️ 441e485 #1 2023-07-27 17:06:12 ~15 min linux/x86_64 📦tgz
✔️ 441e485 #1 2023-07-27 17:15:09 ~24 min windows/x86_64 💿exe
✔️ 441e485 #1 2023-07-27 17:20:31 ~30 min tests/e2e 📄log
✔️ 25def43 #2 2023-07-28 15:49:55 ~4 min tests/imports 📄log
✔️ 25def43 #2 2023-07-28 15:50:39 ~5 min macos/aarch64 🍎dmg
✔️ 25def43 #2 2023-07-28 15:50:58 ~5 min tests/nim 📄log
✔️ 25def43 #2 2023-07-28 15:55:06 ~10 min macos/x86_64 🍎dmg
✔️ 25def43 #2 2023-07-28 15:59:32 ~14 min linux/x86_64 📦tgz
✔️ 25def43 #2 2023-07-28 16:05:56 ~20 min windows/x86_64 💿exe
✔️ 25def43 #2 2023-07-28 16:14:12 ~29 min tests/e2e 📄log
✔️ f13f911 #3 2023-07-31 13:49:56 ~5 min tests/imports 📄log
✔️ f13f911 #3 2023-07-31 13:50:11 ~6 min tests/nim 📄log
✔️ f13f911 #3 2023-07-31 13:58:01 ~13 min macos/x86_64 🍎dmg
✔️ f13f911 #3 2023-07-31 14:00:29 ~16 min linux/x86_64 📦tgz
✔️ f13f911 #3 2023-07-31 14:07:38 ~23 min windows/x86_64 💿exe
✖️ f13f911 #3 2023-07-31 14:12:20 ~28 min tests/e2e 📄log
✔️ f13f911 #3 2023-07-31 14:22:05 ~38 min macos/aarch64 🍎dmg
✔️ 5812663 #4 2023-08-01 10:57:49 ~4 min tests/imports 📄log
✔️ 5812663 #4 2023-08-01 10:59:19 ~6 min tests/nim 📄log
✔️ 5812663 #4 2023-08-01 10:59:23 ~6 min macos/aarch64 🍎dmg
✔️ 5812663 #4 2023-08-01 11:01:39 ~8 min macos/x86_64 🍎dmg
✔️ 5812663 #4 2023-08-01 11:09:42 ~16 min linux/x86_64 📦tgz
✔️ 5812663 #4 2023-08-01 11:26:18 ~33 min tests/e2e 📄log
✔️ 5812663 #4 2023-08-01 11:28:39 ~35 min windows/x86_64 💿exe
✔️ e0e4d1f #5 2023-08-01 12:51:19 ~5 min tests/nim 📄log
✔️ e0e4d1f #5 2023-08-01 12:51:34 ~5 min tests/imports 📄log
✔️ e0e4d1f #5 2023-08-01 12:51:39 ~5 min macos/aarch64 🍎dmg
✔️ e0e4d1f #5 2023-08-01 12:54:25 ~8 min macos/x86_64 🍎dmg
✔️ e0e4d1f #5 2023-08-01 12:59:32 ~13 min linux/x86_64 📦tgz
✔️ 9539765 #6 2023-08-01 13:10:05 ~4 min macos/aarch64 🍎dmg
✔️ 9539765 #6 2023-08-01 13:10:44 ~5 min tests/imports 📄log
✔️ 9539765 #6 2023-08-01 13:10:51 ~5 min tests/nim 📄log
✔️ 9539765 #6 2023-08-01 13:13:40 ~8 min macos/x86_64 🍎dmg
✔️ 9539765 #6 2023-08-01 13:21:28 ~16 min linux/x86_64 📦tgz
✔️ 9539765 #6 2023-08-01 13:34:58 ~29 min tests/e2e 📄log
✔️ 9539765 #6 2023-08-01 13:38:42 ~33 min windows/x86_64 💿exe
✔️ afa8815 #7 2023-08-02 10:17:01 ~4 min tests/imports 📄log
✔️ afa8815 #7 2023-08-02 10:17:46 ~5 min tests/nim 📄log
✔️ afa8815 #7 2023-08-02 10:18:15 ~5 min macos/aarch64 🍎dmg
✔️ afa8815 #7 2023-08-02 10:20:26 ~8 min macos/x86_64 🍎dmg
✔️ afa8815 #7 2023-08-02 10:25:11 ~12 min linux/x86_64 📦tgz
✔️ afa8815 #7 2023-08-02 10:33:22 ~21 min windows/x86_64 💿exe
✔️ afa8815 #7 2023-08-02 10:39:08 ~26 min tests/e2e 📄log
✔️ 4fc0f47 #8 2023-08-02 11:41:27 ~5 min tests/nim 📄log
✔️ 4fc0f47 #8 2023-08-02 11:41:53 ~5 min tests/imports 📄log
✔️ 4fc0f47 #8 2023-08-02 11:44:13 ~7 min macos/aarch64 🍎dmg
✔️ 4fc0f47 #8 2023-08-02 11:45:36 ~9 min macos/x86_64 🍎dmg
✔️ 4fc0f47 #8 2023-08-02 11:49:29 ~13 min linux/x86_64 📦tgz
✔️ 4fc0f47 #8 2023-08-02 11:54:30 ~18 min windows/x86_64 💿exe
✔️ 4fc0f47 #8 2023-08-02 12:05:22 ~29 min tests/e2e 📄log
✔️ f2d07b6 #9 2023-08-02 12:50:58 ~4 min macos/aarch64 🍎dmg
✔️ f2d07b6 #9 2023-08-02 12:51:23 ~5 min tests/imports 📄log
✔️ f2d07b6 #9 2023-08-02 12:51:51 ~5 min tests/nim 📄log
✔️ f2d07b6 #9 2023-08-02 12:54:04 ~7 min macos/x86_64 🍎dmg
✔️ f2d07b6 #9 2023-08-02 12:58:18 ~12 min linux/x86_64 📦tgz
✔️ f2d07b6 #9 2023-08-02 13:08:16 ~22 min windows/x86_64 💿exe
✔️ f2d07b6 #9 2023-08-02 13:12:27 ~26 min tests/e2e 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 20313df #11 2023-08-02 14:24:08 ~5 min tests/nim 📄log
✔️ 20313df #11 2023-08-02 14:24:16 ~5 min tests/imports 📄log
✔️ 20313df #11 2023-08-02 14:25:46 ~7 min macos/aarch64 🍎dmg
✔️ 20313df #11 2023-08-02 14:31:59 ~13 min macos/x86_64 🍎dmg
✔️ 20313df #11 2023-08-02 14:32:40 ~14 min linux/x86_64 📦tgz
✔️ 20313df #11 2023-08-02 14:46:45 ~27 min windows/x86_64 💿exe
✔️ 20313df #11 2023-08-02 14:47:31 ~28 min tests/e2e 📄log
✔️ d0ab188 #12 2023-08-02 15:19:32 ~5 min tests/imports 📄log
✔️ d0ab188 #12 2023-08-02 15:22:16 ~7 min macos/x86_64 🍎dmg
✔️ d0ab188 #12 2023-08-02 15:23:38 ~9 min macos/aarch64 🍎dmg
✔️ d0ab188 #12 2023-08-02 15:23:58 ~9 min tests/nim 📄log
✔️ d0ab188 #12 2023-08-02 15:28:15 ~13 min linux/x86_64 📦tgz
✔️ d0ab188 #12 2023-08-02 15:35:43 ~21 min windows/x86_64 💿exe
✔️ d0ab188 #12 2023-08-02 15:44:27 ~30 min tests/e2e 📄log

@MishkaRogachev MishkaRogachev marked this pull request as draft July 28, 2023 15:44
@MishkaRogachev MishkaRogachev force-pushed the feat/11152-community-management-implement-nb-of-members-graph-backend branch from 441e485 to 25def43 Compare July 28, 2023 15:44
@MishkaRogachev MishkaRogachev force-pushed the feat/11152-community-management-implement-nb-of-members-graph-backend branch 2 times, most recently from e0e4d1f to 9539765 Compare August 1, 2023 13:04
@MishkaRogachev MishkaRogachev marked this pull request as ready for review August 1, 2023 13:08
@caybro caybro self-requested a review August 1, 2023 14:06
jrainville
jrainville requested changes Aug 1, 2023
View reviewed changes
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.

I'm requesting changes just for the wrong module.

src/app/modules/main/communities/controller.nim Outdated Show resolved Hide resolved
src/app/modules/main/communities/view.nim Outdated Show resolved Hide resolved
@MishkaRogachev MishkaRogachev force-pushed the feat/11152-community-management-implement-nb-of-members-graph-backend branch from 9539765 to afa8815 Compare August 2, 2023 10:11
@MishkaRogachev
Copy link
Contributor Author

Added an issue for further work: #11758

@MishkaRogachev MishkaRogachev force-pushed the feat/11152-community-management-implement-nb-of-members-graph-backend branch 2 times, most recently from 4fc0f47 to f2d07b6 Compare August 2, 2023 12:45
jrainville
jrainville approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one comment if you could

src/app/modules/main/chat_section/controller.nim Outdated Show resolved Hide resolved
@MishkaRogachev MishkaRogachev force-pushed the feat/11152-community-management-implement-nb-of-members-graph-backend branch from f2d07b6 to dfb5377 Compare August 2, 2023 14:15
@MishkaRogachev MishkaRogachev force-pushed the feat/11152-community-management-implement-nb-of-members-graph-backend branch from dfb5377 to 20313df Compare August 2, 2023 14:18
@MishkaRogachev @jrainville
Update src/app/modules/main/chat_section/controller.nim
d0ab188 
Co-authored-by: Jonathan Rainville <rainville.jonathan@gmail.com>
alexjba
alexjba approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@alexjba alexjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested and works nicely! 👍

@MishkaRogachev MishkaRogachev merged commit edba946 into master Aug 2, 2023
@MishkaRogachev MishkaRogachev deleted the feat/11152-community-management-implement-nb-of-members-graph-backend branch August 2, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrainville jrainville jrainville approved these changes

@alexjba alexjba alexjba approved these changes

@caybro caybro Awaiting requested review from caybro caybro is a code owner

Assignees
No one assigned
Labels
waiting-for-status-go-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Community Management] Implement nb of members graph (backend)
4 participants
@MishkaRogachev @status-im-auto @jrainville @alexjba