Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Collecting community messages count metrics #3802

Merged
merged 5 commits into from
Aug 1, 2023
Merged

feat: Collecting community messages count metrics #3802

merged 5 commits into from
Aug 1, 2023

Conversation

MishkaRogachev
Copy link
Contributor

@MishkaRogachev MishkaRogachev commented Jul 25, 2023 •
edited
Loading

For status-im/status-desktop#11152

Implement both strategies for fetching community messaging metrics:

  • CommunityMetricsRequestMessagesTimestamps to collect messages timestamps by intervals for all community chats
  • CommunityMetricsRequestMessagesCount to collect messages count by intervals for all community chats

@status-im-auto
Copy link
Member

status-im-auto commented Jul 25, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (40)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 67a635b #1 2023-07-25 14:28:43 ~2 min tests 📄log
✔️ 67a635b #1 2023-07-25 14:29:06 ~3 min linux 📦zip
✔️ 67a635b #1 2023-07-25 14:30:39 ~4 min android 📦aar
✔️ 67a635b #1 2023-07-25 14:35:48 ~9 min ios 📦zip
✖️ d3ab3e1 #2 2023-07-25 17:44:46 ~1 min tests 📄log
✔️ d3ab3e1 #2 2023-07-25 17:45:07 ~1 min linux 📦zip
✔️ d3ab3e1 #2 2023-07-25 17:46:23 ~2 min ios 📦zip
✔️ d3ab3e1 #2 2023-07-25 17:48:37 ~5 min android 📦aar
✖️ 1f7d430 #3 2023-07-26 14:53:25 ~1 min tests 📄log
✔️ 1f7d430 #3 2023-07-26 14:53:58 ~1 min android 📦aar
✔️ 1f7d430 #3 2023-07-26 14:55:20 ~3 min linux 📦zip
✔️ 1f7d430 #3 2023-07-26 14:56:49 ~4 min ios 📦zip
✔️ 35196cc #4 2023-07-26 15:26:50 ~1 min android 📦aar
✔️ 35196cc #4 2023-07-26 15:26:59 ~1 min linux 📦zip
✖️ 35196cc #4 2023-07-26 15:27:59 ~2 min tests 📄log
✔️ 35196cc #4 2023-07-26 15:28:21 ~2 min ios 📦zip
✖️ bca8431 #5 2023-07-28 10:46:00 ~1 min tests 📄log
✔️ bca8431 #5 2023-07-28 10:46:11 ~1 min linux 📦zip
✔️ bca8431 #5 2023-07-28 10:46:48 ~1 min android 📦aar
✔️ bca8431 #5 2023-07-28 10:47:53 ~3 min ios 📦zip
✖️ 434109c #6 2023-07-28 10:47:09 ~1 min tests 📄log
✔️ 434109c #6 2023-07-28 10:47:37 ~1 min linux 📦zip
✔️ 434109c #6 2023-07-28 10:48:40 ~1 min android 📦aar
✔️ 434109c #6 2023-07-28 10:51:03 ~3 min ios 📦zip
✖️ 7025645 #7 2023-07-28 10:51:24 ~1 min tests 📄log
✔️ 7025645 #7 2023-07-28 10:51:50 ~1 min linux 📦zip
✔️ 7025645 #7 2023-07-28 10:52:17 ~1 min android 📦aar
✔️ 7025645 #7 2023-07-28 10:54:08 ~3 min ios 📦zip
✔️ dd39ac8 #8 2023-07-28 11:12:26 ~1 min linux 📦zip
✔️ dd39ac8 #8 2023-07-28 11:13:00 ~2 min android 📦aar
✔️ dd39ac8 #8 2023-07-28 11:14:05 ~3 min ios 📦zip
✖️ dd39ac8 #8 2023-07-28 11:30:24 ~19 min tests 📄log
✔️ 5b8a832 #9 2023-07-28 12:16:49 ~1 min linux 📦zip
✔️ 5b8a832 #9 2023-07-28 12:17:19 ~1 min android 📦aar
✔️ 5b8a832 #9 2023-07-28 12:18:26 ~2 min ios 📦zip
✔️ 5b8a832 #9 2023-07-28 12:35:21 ~19 min tests 📄log
✔️ d24d326 #10 2023-07-31 07:59:41 ~1 min linux 📦zip
✔️ d24d326 #10 2023-07-31 08:00:01 ~1 min android 📦aar
✔️ d24d326 #10 2023-07-31 08:01:30 ~3 min ios 📦zip
✔️ d24d326 #10 2023-07-31 08:13:50 ~15 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c16a95e #11 2023-07-31 14:21:42 ~1 min linux 📦zip
✔️ c16a95e #11 2023-07-31 14:22:24 ~2 min android 📦aar
✔️ c16a95e #11 2023-07-31 14:35:40 ~15 min tests 📄log
✔️ c16a95e #11 2023-07-31 14:36:16 ~16 min ios 📦zip
✔️ b2ace59 #12 2023-08-01 10:58:25 ~2 min android 📦aar
✔️ b2ace59 #12 2023-08-01 10:59:25 ~3 min linux 📦zip
✔️ b2ace59 #12 2023-08-01 10:59:32 ~3 min ios 📦zip
✔️ b2ace59 #12 2023-08-01 11:20:35 ~24 min tests 📄log

@MishkaRogachev MishkaRogachev force-pushed the feat/community-metrics-messages branch from 67a635b to d3ab3e1 Compare July 25, 2023 17:43
@MishkaRogachev MishkaRogachev force-pushed the feat/community-metrics-messages branch 4 times, most recently from 7025645 to dd39ac8 Compare July 28, 2023 11:10
@MishkaRogachev MishkaRogachev marked this pull request as ready for review July 28, 2023 11:10
alexjba
alexjba approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@alexjba alexjba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@MishkaRogachev MishkaRogachev force-pushed the feat/community-metrics-messages branch from dd39ac8 to 5b8a832 Compare July 28, 2023 12:15
jrainville
jrainville approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. This is very clean

ilmotta
ilmotta approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@ilmotta ilmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done @MishkaRogachev! 🚀

protocol/messenger_community_metrics.go Outdated Show resolved Hide resolved
protocol/persistence_metrics.go Show resolved Hide resolved
protocol/requests/community_metrics_request.go Show resolved Hide resolved
@MishkaRogachev MishkaRogachev mentioned this pull request Jul 31, 2023
Merged
@MishkaRogachev MishkaRogachev force-pushed the feat/community-metrics-messages branch from c16a95e to b2ace59 Compare August 1, 2023 10:55
@MishkaRogachev MishkaRogachev merged commit 4ad84d8 into develop Aug 1, 2023
2 checks passed
@MishkaRogachev MishkaRogachev deleted the feat/community-metrics-messages branch August 1, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilmotta ilmotta ilmotta approved these changes

@jrainville jrainville jrainville approved these changes

@alexjba alexjba alexjba approved these changes

@osmaczko osmaczko Awaiting requested review from osmaczko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MishkaRogachev @status-im-auto @ilmotta @jrainville @alexjba